Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable deprecated "form mapping" feature in SonataCoreBundle #9330

Merged
merged 1 commit into from Apr 18, 2018
Merged

Disable deprecated "form mapping" feature in SonataCoreBundle #9330

merged 1 commit into from Apr 18, 2018

Conversation

teohhanhui
Copy link
Contributor

@teohhanhui teohhanhui commented Apr 12, 2018 •
edited

Q A
Branch? master
Bug fix? no (but it removes a lot of deprecation messages)
New feature? no
BC breaks? no? (only in app configuration)
Deprecations? no
Related tickets N/A
License MIT

@teohhanhui teohhanhui mentioned this pull request Apr 12, 2018
Closed
@Zales0123 Zales0123 added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Maintenance CI configurations, READMEs, releases, etc. and removed Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). labels Apr 13, 2018
@teohhanhui
Copy link
Contributor Author

We could have this land in master if you're not comfortable with the (minimal?) risks of breaking some applications...

@pamil pamil self-requested a review April 17, 2018 09:52
@pamil pamil added this to the 1.2 milestone Apr 17, 2018
@pamil
Copy link
Contributor

pamil commented Apr 17, 2018

@teohhanhui good idea, targeting master branch would be the best (as it isn't a bug fix but deprecation fix).

@teohhanhui teohhanhui changed the base branch from 1.0 to master April 17, 2018 15:09
@teohhanhui teohhanhui force-pushed the disable/deprecated-sonata-form-mapping branch from 636e405 to 31b1f4a Compare April 17, 2018 15:22
@teohhanhui
Copy link
Contributor Author

Rebased on master and included an upgrade note.

@pamil pamil merged commit 35153fe into Sylius:master Apr 18, 2018
@pamil
Copy link
Contributor

pamil commented Apr 18, 2018

Awesome, thank you, Teoh! 🎉

@teohhanhui teohhanhui deleted the disable/deprecated-sonata-form-mapping branch April 19, 2018 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teohhanhui @pamil @Zales0123