Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add product in promotion action #9689

Closed
souidev opened this issue Sep 2, 2018 · 12 comments
Closed

add product in promotion action #9689

souidev opened this issue Sep 2, 2018 · 12 comments
Labels
Help Wanted Issues needing help and clarification.

Comments

@souidev
Copy link

souidev commented Sep 2, 2018

Sylius version affected: 1.2.x

Description
https://sylius-older.readthedocs.io/en/latest/book/promotions.html
In this page of doc it says that possible promotion action are :
........
add product (for example: gives a free bonus sticker)
........

i can't figure out how i can do gift product in sylius

@pamil pamil added the Help Wanted Issues needing help and clarification. label Sep 7, 2018
@souidev
Copy link
Author

souidev commented Sep 11, 2018

someone?

@mikemix
Copy link
Contributor

mikemix commented Sep 12, 2018

Obviously the action you mentioned is missing and the docs are outdated regarding this part ;)

@souidev
Copy link
Author

souidev commented Sep 12, 2018

thk @mikemix could it be implemented i think it is necessary to have this feature

@mikemix
Copy link
Contributor

mikemix commented Sep 12, 2018

Well it's not my responsibility to decide on that. Everybody has necessary features too ;)

@Zales0123
Copy link
Member

Hello @souidev and sorry for the late response. First of all, you're using the old version of the documentation, but this action is indeed there in the newest version too 😄 https://sylius.readthedocs.io/en/1.2/book/orders/promotions.html#promotion-actions

It should be for sure deleted from docs. As we've right now entered the feature freeze phase of development (we're heading forward to 1.3 release), we should not add it in the code.

Thank you for reporting! :)

@souidev
Copy link
Author

souidev commented Sep 13, 2018

thk @Zales0123 could this feature be added as a custom action , apparently it is been active in older version of sylius am i right ?

@Zales0123
Copy link
Member

What do you mean by "custom action"? You mean in your custom application? :) That's for sure

@souidev
Copy link
Author

souidev commented Sep 13, 2018

Yes Thank
if anyone have idea how to proceed or already implement this he's welcom to share with us :)
really guys i really need this and i don't have enough time
cordialement

@pamil
Copy link
Contributor

pamil commented Oct 2, 2018

https://docs.sylius.com/en/1.3/cookbook/promotions/custom-promotion-action.html should help you. Also, we recommend you our official support channels: https://docs.sylius.com/en/1.3/support/index.html

@pamil pamil closed this as completed Oct 2, 2018
@bitbager
Copy link
Contributor

bitbager commented Jul 3, 2019

Hi guys! It’s still in the docs though. Any updates on this feature?

@gabiudrescu
Copy link
Contributor

this should be reopened to fix the documentation by removing the mention of obsolete rules that no longer exists.

the feature must either be introduced in Core (though I think it shouldn't) or implemented as a Plugin.

lchrusciel added a commit that referenced this issue Apr 22, 2020
…onger exists in Core. (gabiudrescu)

This PR was merged into the 1.6 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.6
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | fixes #9689 
| License         | MIT


Commits
-------

b84f6d2 Update promotions.rst
@gabiudrescu
Copy link
Contributor

note to future self that arrives here from Google SERPS: the implementation in pre v1.x it is available here: https://github.com/Sylius/Sylius/blob/v0.19.0/src/Sylius/Component/Core/Promotion/Action/AddProductAction.php

in case someone wants to port this to the newer versions of Sylius :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Issues needing help and clarification.
Projects
None yet
Development

No branches or pull requests

6 participants