Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing an unused config option #9946

Closed
mamazu opened this issue Nov 21, 2018 · 4 comments · Fixed by #9964
Closed

Removing an unused config option #9946

mamazu opened this issue Nov 21, 2018 · 4 comments · Fixed by #9964
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).

Comments

@mamazu
Copy link
Member

mamazu commented Nov 21, 2018

Currently the mailer bundle has a configuration that is not needed sylius.mailer.templates

Describe the proposed solution
Deprecate and remove it.

Describe alternatives you've considered
I don't know what this is intended to do.
@CoderMaggie CoderMaggie added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Nov 22, 2018
@Zales0123
Copy link
Member

Indeed, this is the offspring of an old code refactoring, done billion years ago - #6708 :)
Unfortunately, we cannot remove it as somebody can rely on this configuration - it should be deprecated and removed, as you've proposed. Are you willing to open a PR with such a change? Thanks :)

@mamazu
Copy link
Member Author

mamazu commented Nov 26, 2018

Sure thing. However, I though about rewriting the whole module to add channel support.

@mamazu mamazu mentioned this issue Nov 26, 2018
Merged
@Zales0123
Copy link
Member

It would for sure be nice, however, we need to think about BC promise 😕 Thank you for the PR 👍

@mamazu
Copy link
Member Author

mamazu commented Nov 26, 2018

Well if you are intending to release 2.0 anyways then a BC break would be justifiable.

pamil added a commit that referenced this issue Dec 12, 2018
@pamil
refactor #9964 Making templates deprecated (mamazu)
b08dcff 
This PR was merged into the 1.2-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.2, 1.3 or master <!-- see the comment below -->
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | yes
| Related tickets | fixes #9946
| License         | MIT

Deprecating unused config option `sylius.mailer.templates`

<!--
 - Bug fixes must be submitted against the 1.2 or 1.3 branch (the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set
-->


Commits
-------

70cf324 Making templates deprecated
1788d7f Codestyle
94d155b Adding upgrade information
581cdee Fixed typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Making templates deprecated
3 participants
@Zales0123 @CoderMaggie @mamazu