Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making templates deprecated #9964

Merged
merged 4 commits into from Dec 12, 2018
Merged

Making templates deprecated #9964

merged 4 commits into from Dec 12, 2018

Conversation

mamazu
Copy link
Member

@mamazu mamazu commented Nov 26, 2018

Q A
Branch? 1.2, 1.3 or master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Related tickets fixes #9946
License MIT

Deprecating unused config option sylius.mailer.templates

@mamazu mamazu requested a review from a team as a code owner November 26, 2018 14:52
Zales0123
Zales0123 reviewed Nov 26, 2018
View reviewed changes
Copy link
Member

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also mention it in UPGRADE-2.0

src/Sylius/Bundle/MailerBundle/DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
@CoderMaggie CoderMaggie added the DX Issues and PRs aimed at improving Developer eXperience. label Nov 26, 2018
@mamazu
Copy link
Member Author

mamazu commented Nov 26, 2018

Should I also submit a pull request against the 2.0-dev branch to remove it?

loic425
loic425 requested changes Nov 27, 2018
View reviewed changes
UPGRADE-2.0.md Outdated Show resolved Hide resolved
@pamil pamil merged commit b08dcff into Sylius:master Dec 12, 2018
@pamil
Copy link
Contributor

pamil commented Dec 12, 2018

Thanks, @mamazu! 🎉

@pamil
Copy link
Contributor

pamil commented Dec 12, 2018

There's no 2.0 branch yet, we'll do the changes based on UPGRADE-2.0.md file contents (since introducing that branch would make upmerging harder).

@mamazu mamazu deleted the deprecated-templates branch November 17, 2019 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 left review comments

@loic425 loic425 loic425 requested changes

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing an unused config option
5 participants
@mamazu @pamil @Zales0123 @loic425 @CoderMaggie