Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change method to protected #1007

Merged
merged 1 commit into from
Feb 7, 2014
Merged

Change method to protected #1007

merged 1 commit into from
Feb 7, 2014

Conversation

winzou
Copy link
Contributor

@winzou winzou commented Feb 7, 2014

No description provided.

@stloyd
Copy link
Contributor

stloyd commented Feb 7, 2014

@winzou What's the point of this change? You should not call methods on listener to get some data, that is IMO wrong. Please give a use-case for this change.

@winzou
Copy link
Contributor Author

winzou commented Feb 7, 2014

I'm overriding this listener, and to customize method updateShipmentStates I need to get order from event. Don't want to rewrite a getOrderBis that would do the same. It's only protected, not public =)

@stloyd
Copy link
Contributor

stloyd commented Feb 7, 2014

D'oh... sorry, I need coffee... I'm sure I was seeing there the public keyword -.-

@stloyd stloyd added this to the 1.0.0-BETA1 milestone Feb 7, 2014
stloyd added a commit that referenced this pull request Feb 7, 2014
@stloyd stloyd merged commit 4298ffb into Sylius:master Feb 7, 2014
@winzou winzou deleted the fix/listener branch February 7, 2014 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants