Numberformatter intl bugs with negative numbers #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,6 +30,10 @@ public function __construct(CurrencyContextInterface $currencyContext, CurrencyC | |||
| $this->currencyContext = $currencyContext; | |||
| $this->converter = $converter; | |||
| $this->formatter = new \NumberFormatter($locale ?: \Locale::getDefault(), \NumberFormatter::CURRENCY); | |||
|
|
|||
| $sMyPattern = "¤#,##0.00;-¤#,##0.00"; | |||
…or it. This solve the behat failures for checking promotional discounts (most locales show negative number as: -$100.00, en-US shows ($100.00) Fixes Sylius#853 along with other issues.
|
@pjedrzejewski Fixed. Thanks! |
pjedrzejewski
pushed a commit
that referenced
this pull request
Feb 17, 2014
…sting Numberformatter intl bugs with negative numbers
|
Thank you Myke! 👍 |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…tterTesting Numberformatter intl bugs with negative numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing must take place in the en_US locale AND our number formatter must change the pattern
This solve the behat failures for checking promotional discounts (most locales
show negative number as: -$100.00. There is no dependable locale across different versions of pecl-intl that display negative currencies the same.
Fixes #853 along with other issues.