-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use email instead of username #103
Conversation
Nice, for sure you also have to update the scenarios. :) |
TBH. I would prefer to give a choice for developer which type of authentication he wants:
|
@stloyd could be interesting but how do you do that? |
simply by configuring this https://github.com/FriendsOfSymfony/FOSUserBundle/blob/master/Resources/doc/logging_by_username_or_email.md :) a key in parameters.yml could do the trick |
OK but you still have to make different registration/login forms for each cases.
|
@pjedrzejewski I've updated scenarios. |
Convert translations
Link Address and User
Requires rebase against latest master. :) |
Waw, I don't really know what I've just done with the rebase. It seems OK but github shows all the merged commits again, I don't know if it's a good thing. @pjedrzejewski can you still merge that or not? |
@winzou Can you pick only the right commits and fix this branch or reopen this PR? If no, I'll try to fix it! :) |
I should be able to do that tonight I'll let you know. |
See #144 for clean PR. |
Renaming SalesBundle to OrderBundle
Make tax 20% and included in price
As stated in #88