Shipment state on hold while payment is processing

[umpirsky]

Part of https://github.com/Sylius/Sylius/wiki/Status#wiki-successful-order.

BTW @pjedrzejewski @winzou We extended state resolver internally to resolve order state, it looks sth like this https://gist.github.com/umpirsky/2008fc7ca2484631b7f7 What do you think? Can we have something similar in Sylius?

[winzou]

+1 for the PR.

+1 as well for you resolver. But I think we need something more powerful. We have lots of states, lots of different state types, and quite complex relations between all of them. I feel there must be a place where everything is centralized and right events dispatched at the right time. It's currently way too much spread everywhere is the code, and I'm sure it's not consistent in every cases (because we forgot to dispatch certain events, etc.).

[umpirsky]

@winzou I'm curious to see how more powerful resolver looks like.

@pjedrzejewski And yet again, the question is, do we need order state at all?

[winzou]

Sorry, I was not really clear, I'm not thinking of just a resolver but a full "state manager" that would handle all kind of states, dispatch events, etc. and eventually resolve this order state.

And I think yes we need order states, because it simplifies UI. Especially when stores have their own shipping/inventory/whatever states, then we can still rely on some generic order states. What do you think?

[umpirsky]

Sounds OK. 👍

[pjedrzejewski]

User panel orders section scenario is failing. Otherwise 👍.

[winzou]

@umpirsky requires rebase.

[umpirsky]

Rebased.

[pjedrzejewski]

Thank you Sasha.