Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResourceBundle][Proposal/idea] Define a prefix or appName #1075

Merged
merged 1 commit into from
Feb 18, 2014

Conversation

arnolanglade
Copy link
Contributor

It avoid to override mapClassParameters mapValidationGroupParameters loadDatabaseDriver if you don't use 'sylius' by default.

Another idea : we can rename sylius.config.classes (defined in BaseExtension line 84) to resource.config.classes which is more generic.

@@ -32,6 +32,7 @@
const CONFIGURE_PARAMETERS = 4;
const CONFIGURE_VALIDATORS = 8;

protected $applicationNane = 'sylius';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$applicationName :)

@jjanvier
Copy link
Contributor

👍

@arnolanglade
Copy link
Contributor Author

@umpirsky : Done :D and do you think about resource.config.classes?

pjedrzejewski pushed a commit that referenced this pull request Feb 18, 2014
[ResourceBundle][Proposal/idea] Define a prefix or appName
@pjedrzejewski pjedrzejewski merged commit 74c8cf7 into Sylius:master Feb 18, 2014
@pjedrzejewski
Copy link
Member

👍 Thanks Arnaud! Regarding the resource.config.classes... not sure what you mean?

@arnolanglade
Copy link
Contributor Author

I spoke about rename the key sylius.config.classes :

        if ($container->hasParameter('resource.config.classes')) {
            $classes = array_merge($classes, $container->getParameter('resource.config.classes'));
        }
        $container->setParameter('resource.config.classes', $classes);

We can add a protected method to add extra classes too.

@arnolanglade
Copy link
Contributor Author

I can send a new PR, you can close it if you are not agree.

@arnolanglade arnolanglade deleted the app-name branch December 16, 2014 12:54
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
[ResourceBundle][Proposal/idea] Define a prefix or appName
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). RFC Discussions about potential changes or new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants