Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] add php 7.4 to travis #10994

Closed
wants to merge 4 commits into from
Closed

[WIP] add php 7.4 to travis #10994

wants to merge 4 commits into from

Conversation

oallain
Copy link
Member

@oallain oallain commented Dec 30, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets License

Just add PHP version 7.4 in Travis.

@oallain oallain requested a review from a team as a code owner December 30, 2019 17:58
@pamil pamil added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Maintenance CI configurations, READMEs, releases, etc. labels Dec 30, 2019
@oallain oallain force-pushed the travis-php74 branch 2 times, most recently from e5295da to facdca8 Compare December 30, 2019 20:22
@oallain oallain changed the title add php 7.4 to travis [WIP] add php 7.4 to travis Dec 30, 2019
@oallain
Copy link
Member Author

oallain commented Dec 30, 2019 •
edited

In travis logs we can see a lot of :
Deprecated: Array and string offset access syntax with curly braces is deprecated in /home/travis/build/Sylius/Sylius/vendor/behat/transliterator/src/Behat/Transliterator/Transliterator.php on line 357 see https://travis-ci.org/Sylius/Sylius/jobs/631065921#L1414

This is fixed in Behat/Transliterator#29 we just need a new release.
Or we can switch to symfony/string 😄

@pamil
Copy link
Contributor

pamil commented Dec 31, 2019

I'm good with using Symfony String component, although it's still experimental as of Symfony 5.0. On the other hand, I wouldn't put much hope in Behat/Transliterator getting tagged.

@pamil
Copy link
Contributor

pamil commented Dec 31, 2019

Anyway, if it's just a deprecation, I'd address it in an another PR.

@oallain oallain force-pushed the travis-php74 branch 2 times, most recently from 8cc8ea2 to d9e04ea Compare January 11, 2020 21:07
@oallain
Copy link
Member Author

oallain commented Jan 11, 2020

I don't understand why a got this error in Behat :(

@pamil
Copy link
Contributor

pamil commented Jan 14, 2020

Btw. behat/transliterator v1.3.0 has been released, so we don't need to change to symfony/string yet. I have no idea why it fails though :(

@oallain
Copy link
Member Author

oallain commented Jan 15, 2020

Good news for behat/transliterator i revert 😄

@oallain oallain force-pushed the travis-php74 branch 3 times, most recently from ad5496f to d73f568 Compare January 20, 2020 18:25
@oallain oallain mentioned this pull request Jan 20, 2020
Closed
@oallain
Copy link
Member Author

oallain commented Jan 20, 2020

I nned help 🆘

@diimpp
Copy link
Member

diimpp commented Mar 4, 2020

Would be cool to have before 1.7 release :)

@lchrusciel
Copy link
Member

Too late, but I suppose we can think about adding support for 7.4 in patch ;)

@oallain oallain force-pushed the travis-php74 branch 2 times, most recently from 47ffd62 to 875e590 Compare March 7, 2020 18:33
@oallain oallain force-pushed the travis-php74 branch 3 times, most recently from 0788c88 to 0b3d393 Compare April 5, 2020 19:37
@pamil
Copy link
Contributor

pamil commented May 12, 2020

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "travis-php74" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@pamil pamil changed the base branch from master to 1.7 May 12, 2020 21:03
@pamil
Copy link
Contributor

pamil commented May 12, 2020

Rebased to 1.7, let's see what would happen to the build 🎉

Zales0123
Zales0123 reviewed May 13, 2020
View reviewed changes
.travis.yml Outdated
@@ -1,7 +1,5 @@
language: php

dist: trusty
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm struggling with javascript scenarios on some newer version of Travis ubuntu for some time already (see this). I don't know why it does not work properly. We don't see it in the build, but the problem is WebDriver\Exception\InvalidCookieDomain: invalid cookie domain. Maybe you've already encountered it?

Nevertheless, for this PR, can't we stay with Ubuntu Trusty yet? Or PHP 7.4 is not available on it?

@pamil
Copy link
Contributor

pamil commented May 14, 2020

It's possible to use PHP 7.4 on Trusty, but there's no GD extension then.

@oallain
Copy link
Member Author

oallain commented May 15, 2020

Yes, You can see test at https://travis-ci.org/github/Sylius/Sylius/jobs/687353959

@pamil
Copy link
Contributor

pamil commented May 20, 2020

@oallain what about trying to get our current Travis configuration work with Xenial and then add PHP 7.4 once it passes?

@oallain
Copy link
Member Author

oallain commented May 25, 2020

@oallain what about trying to get our current Travis configuration work with Xenial and then add PHP 7.4 once it passes?

Yep, we can probably do that but I don't have time this week :/

@pamil
Copy link
Contributor

pamil commented May 26, 2020

No worries! Tried to make it work in #11505 (going straight to Bionic 18.04 instead of Xenial 16.04), a few scenarios failing.

@pamil pamil mentioned this pull request May 26, 2020
Merged
@pamil pamil closed this in #11505 May 26, 2020
pamil added a commit that referenced this pull request May 26, 2020
@pamil
minor #11505 Travis Bionic + Chrome Headless + PHP 7.4 support (pamil)
fface1c 
This PR was merged into the 1.8-dev branch.

Discussion
----------

- Moved from Ubuntu 14.04 (Trusty) to 18.04 (Bionic).
- Replaced Selenium + Chromedriver + Chrome with Chrome Headless for running JS Behat scenarios.
- Added support for PHP 7.4.

Closes #10994.

JS suite sped up from ~13m to ~8,5m.

Commits
-------

22fbf51 Travis Bionic + Chrome Headless + PHP 7.4 support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil left review comments

@Zales0123 Zales0123 Zales0123 left review comments

Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@oallain @pamil @diimpp @lchrusciel @Zales0123