Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial i18n support for products #110

Closed
wants to merge 1 commit into from

Conversation

umpirsky
Copy link
Contributor

@jjanvier
Copy link
Contributor

👍 I didn't know A2lixTranslationFormBundle. Great discover, thanks ;)

@@ -51,13 +51,17 @@ doctrine:
enabled: true

stof_doctrine_extensions:
default_locale: %sylius.locale%
default_locale: en
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of this. It does not passes since $locale and $this->defaultLocale have same value, so it does not translate.
So, in order to work, you must pick default locale (eg English), and it loads translated values only if current locale is different from default locale.
Default locale values are stored in Product, and for each locale different from default locale in ProductTranslation.

@ekyna
Copy link
Contributor

ekyna commented May 28, 2013

Maybe it would be better to have a locale switcher in the main/side nav bar instead of placing all translations in the same form ?

@pjedrzejewski
Copy link
Member

@ekyna I agree, we need to look at this feature again. Closing for now.

@rudott
Copy link

rudott commented Mar 27, 2014

@pjedrzejewski is there any progress i18n support for products, taxons, etc.? Thanks!

@egogarcia
Copy link
Contributor

Any new?

@pjedrzejewski
Copy link
Member

@egogarcia See #2101.

@nichchung
Copy link

are these fixes in the dev version, or the stable version? as of today, it seems like the latest productbundle fixes are included in sylius-standard, but I don't think the above commits are. Thanks in advance for any assistance!

pamil pushed a commit to pamil/Sylius that referenced this pull request Mar 21, 2016
CoderMaggie pushed a commit to CoderMaggie/Sylius that referenced this pull request Jun 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants