-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial i18n support for products #110
Conversation
👍 I didn't know A2lixTranslationFormBundle. Great discover, thanks ;) |
@@ -51,13 +51,17 @@ doctrine: | |||
enabled: true | |||
|
|||
stof_doctrine_extensions: | |||
default_locale: %sylius.locale% | |||
default_locale: en |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of this. It does not passes since $locale and $this->defaultLocale have same value, so it does not translate.
So, in order to work, you must pick default locale (eg English), and it loads translated values only if current locale is different from default locale.
Default locale values are stored in Product, and for each locale different from default locale in ProductTranslation.
Maybe it would be better to have a locale switcher in the main/side nav bar instead of placing all translations in the same form ? |
@ekyna I agree, we need to look at this feature again. Closing for now. |
@pjedrzejewski is there any progress i18n support for products, taxons, etc.? Thanks! |
Any new? |
@egogarcia See #2101. |
are these fixes in the dev version, or the stable version? as of today, it seems like the latest productbundle fixes are included in sylius-standard, but I don't think the above commits are. Thanks in advance for any assistance! |
Sylius update and few fixes
Depends on Sylius/SyliusAssortmentBundle#79
Fixes https://github.com/Sylius/SyliusAssortmentBundle/issues/48