[API] Product options (with values) creation and index #11136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tomanhez
reviewed
Feb 24, 2020
lchrusciel
approved these changes
Feb 24, 2020
Zales0123
changed the title
Zales0123
changed the title
Zales0123
force-pushed
the
product-options-api
branch
from
028240f
to
922cb96
Compare
Zales0123
force-pushed
the
product-options-api
branch
from
922cb96
to
beb6326
Compare
pamil
approved these changes
Feb 25, 2020
|
Thank you, Mateusz! 馃 |
pamil
reviewed
Feb 25, 2020
| <property name="createdAt" writable="false" /> | ||
| <property name="updatedAt" writable="false" /> | ||
| <property name="values" readable="true" writable="true"> | ||
| <subresource resourceClass="Sylius\Component\Product\Model\ProductOptionValue" collection="true" /> |
There was a problem hiding this comment.
What about not using subresources for values but IRIs instead?
This was referenced Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR consists of API for creation and indexing product options (with product option values as sub-resources):
It also contains a PoC of the Behat extension, that does not allow to run a javascript session for API scenarios with multiple tags (like
@ui @javascript @api) 馃拑