Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Minor fixes after tax categories api configured #11162

Merged
merged 1 commit into from
Mar 9, 2020
Merged

[API] Minor fixes after tax categories api configured #11162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Sylius/Behat/Context/Api/Admin/ManagingTaxCategoriesContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ public function iShouldNotBeAbleToEditItsCode(): void
* @Then /^(this tax category) name should be "([^"]+)"$/
* @Then /^(this tax category) should still be named "([^"]+)"$/
*/
public function thisTaxCategoryNameShouldBe(TaxCategoryInterface $taxCategory, $taxCategoryName): void
public function thisTaxCategoryNameShouldBe(TaxCategoryInterface $taxCategory, string $taxCategoryName): void
{
$this->client->show('tax_categories', $taxCategory->getCode());
Assert::true($this->client->responseHasValue('name', $taxCategoryName), sprintf('Tax category name is not %s', $taxCategoryName));
Expand Down
13 changes: 8 additions & 5 deletions src/Sylius/Behat/Resources/config/services/contexts/api.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,16 @@
<argument type="service" id="sylius.behat.shared_storage" />
</service>

<service id="sylius.behat.context.api.admin.managing_taxons" class="Sylius\Behat\Context\Api\Admin\ManagingTaxonsContext">
<service id="sylius.behat.context.api.admin.managing_product_variants" class="Sylius\Behat\Context\Api\Admin\ManagingProductVariantsContext">
<argument type="service" id="test.client" />
<argument type="service" id="session" />
</service>
<service id="sylius.behat.context.api.admin.managing_product_variants" class="Sylius\Behat\Context\Api\Admin\ManagingProductVariantsContext">

<service id="sylius.behat.context.api.admin.managing_tax_categories" class="Sylius\Behat\Context\Api\Admin\ManagingTaxCategoriesContext">
<argument type="service" id="Sylius\Behat\Client\ApiClientInterface" />
</service>

<service id="sylius.behat.context.api.admin.managing_taxons" class="Sylius\Behat\Context\Api\Admin\ManagingTaxonsContext">
<argument type="service" id="test.client" />
<argument type="service" id="session" />
</service>
Expand All @@ -49,9 +54,7 @@
<service id="sylius.behat.context.api.admin.notification" class="Sylius\Behat\Context\Api\Admin\NotificationContext">
<argument type="service" id="Sylius\Behat\Client\ApiClientInterface" />
</service>
<service id="sylius.behat.context.api.admin.managing_tax_categories" class="Sylius\Behat\Context\Api\Admin\ManagingTaxCategoriesContext">
<argument type="service" id="Sylius\Behat\Client\ApiClientInterface" />
</service>

<service id="sylius.behat.context.api.admin.managing_customer_groups" class="Sylius\Behat\Context\Api\Admin\ManagingCustomerGroupsContext">
<argument type="service" id="Sylius\Behat\Client\ApiClientInterface" />
</service>
Expand Down