[API][Product review] Minor fixes after product review api merged #11197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AdamKasp
commented
Mar 9, 2020
AdamKasp
commented
| Q | A |
|---|---|
| Branch? | api |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| License | MIT |
Zales0123
approved these changes
Mar 9, 2020
lchrusciel
reviewed
Mar 9, 2020
| @@ -11,15 +11,15 @@ Feature: Recalculating product average rating | |||
| And this product has a review titled "Not bad" and rated 3 with a comment "Not bad car" added by customer "specter@teamharvey.com" | |||
| And I am logged in as an administrator | |||
|
|
|||
| @ui @api @javascript | |||
There was a problem hiding this comment.
Why did you turn off these tests?
There was a problem hiding this comment.
because following by suggestion @GSadee (#11173 (comment)) i deleted from ManagingProductReviewContext step And average rating of product "Lamborghini Gallardo Model" should be 4 (because it will be covered in product context). So, for now, this step isn't full implemented
AdamKasp
force-pushed
the
minor-fixes-after-product-review-api-merged
branch
from
bdb2956
to
98a069a
Compare
lchrusciel
approved these changes
Mar 10, 2020
AdamKasp
force-pushed
the
minor-fixes-after-product-review-api-merged
branch
from
98a069a
to
86a6f7d
Compare
Zales0123
approved these changes
Mar 10, 2020
Zales0123
added
API
|
Thank you, Adam! 🎉 |
|
Part of #11250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.