[API] [Product] [ProductTranslation] Add api configuration and test for adding product and product translations #11213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Tomanhez
commented
Mar 11, 2020
Tomanhez
commented
| Q | A |
|---|---|
| Branch? | api |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
Tomanhez
force-pushed
the
crud-product
branch
2 times, most recently
from
dc1326f
to
bdade86
Compare
lchrusciel
reviewed
Mar 12, 2020
Comment on lines
53
to
54
| $data = ['translations' => [$language => ['locale' => $language]]]; | ||
| $data['translations'][$language]['name'] = $name; |
There was a problem hiding this comment.
Suggested change
| $data = ['translations' => [$language => ['locale' => $language]]]; | |
| $data['translations'][$language]['name'] = $name; | |
| $data = [ | |
| 'translations' => [ | |
| $language => [ | |
| 'locale' => $language, | |
| 'name' => $name, | |
| ], | |
| ], | |
| ]; |
There was a problem hiding this comment.
What will happen if 'locale' => $language will be omitted?
| */ | ||
| public function iSetItsSlugTo(?string $slug = null, $language = 'en_US'): void | ||
| { | ||
| $data = ['translations' => [$language => ['slug' => $slug]]]; |
There was a problem hiding this comment.
Why is this configuration different than the configuration for the name field?
There was a problem hiding this comment.
Is problem with doubling locale key when array is merged in addCompoundRequestData(), I think that this method should be refactored
AdamKasp
reviewed
Mar 12, 2020
src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/ProductTranslation.xml
Outdated
Show resolved
Hide resolved
GSadee
added
Admin
GSadee
reviewed
Mar 12, 2020
src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ProductTranslation.xml
Outdated
Show resolved
Hide resolved
Tomanhez
force-pushed
the
crud-product
branch
2 times, most recently
from
443576b
to
50628ea
Compare
lchrusciel
approved these changes
Mar 13, 2020
lchrusciel
reviewed
Mar 13, 2020
| $data = [ | ||
| 'translations' => [ | ||
| $localeCode => [ | ||
| 'slug' => $slug, |
There was a problem hiding this comment.
This should work now:
Suggested change
| 'slug' => $slug, | |
| 'locale' => $localeCode, | |
| 'slug' => $slug, |
| */ | ||
| public function theProductShouldAppearInTheShop(string $productName): void | ||
| { | ||
| $this->client->index(); |
There was a problem hiding this comment.
Suggested change
| $this->client->index(); | |
| $response = $this->client->index(); |
| Assert::true( | ||
| $this | ||
| ->responseChecker | ||
| ->hasItemWithTranslation($this->client->getLastResponse(),'en_US', 'name', $productName) |
There was a problem hiding this comment.
Suggested change
| ->hasItemWithTranslation($this->client->getLastResponse(),'en_US', 'name', $productName) | |
| ->hasItemWithTranslation($response, 'en_US', 'name', $productName) |
| $this | ||
| ->responseChecker | ||
| ->hasItemWithTranslation($this->client->getLastResponse(),'en_US', 'name', $productName) | ||
| ); |
| */ | ||
| public function iShouldBeNotifiedThatItHasBeenSuccessfullyCreated(): void | ||
| { | ||
| Assert::true($this->responseChecker->isCreationSuccessful($this->client->getLastResponse())); |
|
Thank you, Tomasz! 🥇 |
|
Part of #11250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.