[API] shipping shipment with tracking code + minor fixes #11231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AdamKasp
commented
Mar 16, 2020
AdamKasp
commented
| Q | A |
|---|---|
| Branch? | api |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
GSadee
added
Admin
GSadee
approved these changes
Mar 16, 2020
|
Thanks, Adam! 🎉 |
lchrusciel
reviewed
Mar 16, 2020
| Scenario: Shipping a shipment with tracking code from shipments index | ||
| When I browse shipments | ||
| And I ship the shipment of order "#00000001" with "AWDDXS-SAAQQ-SEFFX-CCDSE" tracking code | ||
| Then I should be notified that the shipment has been successfully shipped | ||
| And an email with the shipment's confirmation of the order "#00000001" should be sent to "donald@duck.com" | ||
|
|
||
| @ui @api @email |
There was a problem hiding this comment.
Why have you deleted this tag?
There was a problem hiding this comment.
in this PR I fixed comment from #11230, here I added by mistake @email tag so now i have removed it (this scenario does not have any email-related steps)
| @@ -32,8 +32,6 @@ | |||
| <itemOperation name="get" /> | |||
| </itemOperations> | |||
|
|
|||
| <collectionOperations /> | |||
There was a problem hiding this comment.
Because we have it inline 29 - i fixed mistake after merge :( (btw i will move it above itemOperations i next PR :) )
|
Part of #11250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.