[Docs] Add changes in UPGRADE-1.8.md #11852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Tomanhez
commented
Sep 16, 2020
Tomanhez
commented
| Q | A |
|---|---|
| Branch? | 1.8 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
probot-autolabeler
bot
added
the
Maintenance
pamil
approved these changes
Sep 16, 2020
lchrusciel
approved these changes
Sep 16, 2020
Comment on lines
+45
to
+46
| admin: | ||
| remember_me: |
There was a problem hiding this comment.
Suggested change
| admin: | |
| remember_me: | |
| + admin: | |
| + remember_me: |
There was a problem hiding this comment.
Keys admin , remember_me and access_control already exists, I think that we should and + to new lines
| @@ -74,15 +84,53 @@ | |||
| + guard: | |||
| + authenticators: | |||
| + - lexik_jwt_authentication.jwt_token_authenticator | |||
| + | |||
| access_control: | |||
There was a problem hiding this comment.
Suggested change
| access_control: | |
| + access_control: |
|
The dynamic admin path is incorrect in the configurations diffs. |
jacquesbh
suggested changes
Sep 16, 2020
Tomanhez
force-pushed
the
improve-upgrade-file-1.8
branch
from
52d64eb
to
7427eb7
Compare
GSadee
reviewed
Sep 17, 2020
Tomanhez
force-pushed
the
improve-upgrade-file-1.8
branch
from
7427eb7
to
72db2ed
Compare
GSadee
approved these changes
Sep 21, 2020
|
Thanks, Tomasz! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.