[API] changing password #11962
[API] changing password #11962
Conversation
arti0090
commented
Oct 26, 2020
arti0090
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
src/Sylius/Bundle/ApiBundle/CommandHandler/ChangePasswordShopUserHandler.php
Outdated
Show resolved
Hide resolved
| @@ -6,12 +6,12 @@ Feature: Changing a customer password | |||
|
|
|||
| Background: | |||
| Given the store operates on a single channel in "United States" | |||
| And there is a customer "Francis Underwood" identified by an email "francis@underwood.com" and a password "whitehouse" | |||
| And there is a customer "Francis Underwood" identified by an email "francis@underwood.com" and a password "sylius" | |||
There was a problem hiding this comment.
Ok but unnecessary change for this PR
There was a problem hiding this comment.
This is why it was easier to change password than refactoring for any password. We can think about this change in another PR maybe
| @@ -144,6 +144,28 @@ public static function custom(string $url, string $method): RequestInterface | |||
| ); | |||
| } | |||
|
|
|||
| public static function customUpdate(?string $section, ?string $resource, ?string $id = null, ?string $urlResource = null, ?string $token = null): RequestInterface | |||
There was a problem hiding this comment.
Why did you need this method? Couldn't you use update or custom method?
There was a problem hiding this comment.
custom is using ['CONTENT_TYPE' => 'application/merge-patch+json'] which does not work with this update.
And update is not designated for collection command but for item operation ( it needs id).
Other way to solve it, i can use /** @var AbstractBrowser */ and create custom request $this->client->request(), but it might cause the all accountContext to be changed. Wdyt @GSadee ??
There was a problem hiding this comment.
Naming is misleading in this case. By default, POST operation suggests the creation of the object. This endpoint is declared as POST and it is a collection operation, which is not exactly true. We are operating on a particular item, but we wanted to skip user id from URI (and have account endpoint).
src/Sylius/Bundle/ApiBundle/CommandHandler/ChangePasswordShopUserHandler.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/CommandHandler/ChangePasswordShopUserHandler.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/Commands/ChangePasswordShopUser.xml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Resources/config/validation/ChangePasswordShopUser.xml
Outdated
Show resolved
Hide resolved
arti0090
force-pushed
the
api-changing-password
branch
from
c030eb8
to
bcaa9d9
Compare
