Price calculators

[umpirsky]

Fixes issue #1120.

This will allow us to have custom price calculators. For example, we have something like this in our project.

<?php

namespace Sylius\Bundle\CoreBundle\Calculator;

use Sylius\Bundle\CoreBundle\Entity\Variant;
use Sylius\Bundle\CoreBundle\Provider\RegionalPriceProvider;

class RegionalPriceCalculator implements PriceCalculatorInterface
{
    private $regionalPriceProvider;

    public function __construct(RegionalPriceProvider $regionalPriceProvider)
    {
        $this->regionalPriceProvider = $regionalPriceProvider;
    }

    public function calculate(Variant $variant)
    {
        return $this->regionalPriceProvider->getRegionalCurrentPrice($variant);
    }
}

[winzou]

Old one was nice as well ;)

[umpirsky]

It was better :)

[winzou]

But you display wrong price in frontend?
This calculator is nice, we shouldn't have all these calculate methods in Order and OrderItem.

[umpirsky]

@winzou Ah, true. Missed that :)

Will fix, thanks.

[kayue]

Cool stuff 👍

[stloyd]

Default calculator simply returns the variant price.

[umpirsky]

@winzou umpirsky@85c67f8

[winzou]

I would totally separate the formatting from the calculation. Like this: {{ variant.price|calculate|sylius_price }} or even in the function style (maybe more intuitive than filter): {{ calculate(variant)|sylius_price }}

[kayue]

Agree with @winzou on function style. Maybe calculate_price()?

And beside variant, should we accept Product?

[stloyd]

TBH. it's kinda confusing for me where to put this code. IMO it's not totally correct to have it in the CoreBundle, while all prices are being calculated by MoneyBundle... I'm confused.

Anyway, we can't depend on Variable only, we should support Product too, as in Product you have i.e. getMasterVariant()...

[kayue]

@stloyd Where does MoneyBundle calculate price? I thought MoneyBundle was just doing currency exchange.

If we put PriceCalculator to MoneyBundle, that would make MoneyBundle depends on Variant wouldn't it?

[pjedrzejewski]

PricingBundle. Would be cool to put it there... I'll put your implementation on steroids later. (add optional configuration to pricing calculators) What do you think?

[pjedrzejewski]

And I'd go with PriceableInterface. Instead of relying on the variant. It could return the price calculator name and configuration. (in future)

[stloyd]

@pjedrzejewski I would say that bundle is overkill, component sound ok but bundle is overkill ;)

But totally agree about that interface, I was thinking about same thing, but placed in ProductBundle, or in MoneyBundle, but prefer the first one

[pjedrzejewski]

IMHO, it definitely should be a separate bundle. In @umpirsky implementation it is quite thin, but for sure it will contain much more and can be used separately from Product bundle. Why would you couple the pricing stuff only to Product bundle?

[umpirsky]

@winzou I agree about {{ calculate(variant)|sylius_price }}, will update.

@pjedrzejewski I agree about PriceableInterface, will update. What about keeping it in core for now as long as it is this tiny. We can move it to component or separate bundle once you decide to put it on fire with configuration etc?

[pjedrzejewski]

@umpirsky Deal! 👍

[umpirsky]

@pjedrzejewski Ready for merging. Just waiting for Travis.

[umpirsky]

@pjedrzejewski Can you merge it please?

[pjedrzejewski]

Thanks Sasha! The build was failing previously. Nice work! 👍