Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHPStan and its configuration #12058

Merged
merged 1 commit into from
Nov 24, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,8 @@
"mockery/mockery": "^1.4",
"pamil/prophecy-common": "^0.1",
"phpspec/phpspec": "^7.0",
"phpstan/phpstan": "0.12.29",
"phpstan/phpstan-doctrine": "0.12.16",
"phpstan/phpstan": "0.12.56",
"phpstan/phpstan-doctrine": "0.12.22",
"phpunit/phpunit": "^8.5",
"psalm/plugin-mockery": "0.6.1",
"psr/event-dispatcher": "^1.0",
Expand Down
30 changes: 1 addition & 29 deletions phpstan.neon
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,8 @@ parameters:
reportUnmatchedIgnoredErrors: false

excludes_analyse:
# Makes PHPStan crash
- '**/DependencyInjection/Configuration.php'

# Test dependencies
- '**/Bundle/*/spec/**.php'
- '**/spec/**.php'
- '**/Bundle/*/test/app/**.php'
- '**/Bundle/*/test/src/**.php'
- '**/Bundle/*/Tests/Functional/app/**.php'
Expand All @@ -19,33 +16,8 @@ parameters:
- '**/Bundle/*/vendor/**.php'
- '**/Component/*/vendor/**.php'

# These packages aren't in require-dev of the global package
- '**MongoDB**'
- '**ODM**'

# Deprecated classes
- 'src/Sylius/Bundle/CoreBundle/Application/Kernel.php'

ignoreErrors:
# Magic calls
- '/Call to an undefined method Faker\\Generator::/'
- '/Access to an undefined property Faker\\Generator::/'
- '/Method Mockery\\MockInterface::shouldReceive\(\) invoked with 1 parameter, 0 required/'
- '/Call to an undefined method Symfony\\Component\\Config\\Definition\\Builder\\NodeParentInterface/'
- '/Call to an undefined method Mockery\\ExpectationInterface|Mockery\\HigherOrderMessage::/'

# PhpSpec related errors
- '/Access to an undefined property spec\\/'
- '/Call to an undefined method spec\\/'
- '/Call to an undefined static method spec\\/'

# These packages aren't in require-dev of the global package
- '/Class Doctrine\\Bundle\\MongoDBBundle/'
- '/Class Doctrine\\Bundle\\PHPCRBundle/'

# Symfony 4.0 BC layer
- '/Symfony\\Component\\ExpressionLanguage\\ParserCache\\ParserCacheInterface/'
- '/Symfony\\Component\\ExpressionLanguage\\ParserCache\\ParserCacheAdapter/'
- '/Class Symfony\\Component\\Config\\Definition\\Builder\\TreeBuilder does not have a constructor and must be instantiated without any parameters/'

- '/Access to an undefined property Doctrine\\Common\\Collections\\ArrayCollection/'
9 changes: 0 additions & 9 deletions symfony.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1036,9 +1036,6 @@
"symfony/yaml": {
"version": "v4.4.13"
},
"symplify/auto-bind-parameter": {
"version": "v8.2.9"
},
"symplify/autowire-array-parameter": {
"version": "v8.2.9"
},
Expand All @@ -1054,12 +1051,6 @@
"symplify/package-builder": {
"version": "8.2.21"
},
"symplify/parameter-name-guard": {
"version": "v8.2.1"
},
"symplify/phpstan-extensions": {
"version": "v8.1.19"
},
"symplify/set-config-resolver": {
"version": "8.2.21"
},
Expand Down