Add "Canceled" shipment state.

[kayue]

Should we...

• Add a new "Canceled" shipment state.
• Remove the old "Dispatched" state, it is not being use in anywhere.

Reference: http://guides.spreecommerce.com/developer/shipments.html

[pjedrzejewski]

Yes, I think it makes perfect sense. @winzou opinions?

[kayue]

Done.

[pjedrzejewski]

@Sylius Cancelled vs. Canceled? Afaik, Canceled is OK in American English, but Cancelled is preferred in other countries... opinions?

[umpirsky]

I prefer cancelled.
On 16 Mar 2014 20:10, "Paweł Jędrzejewski" notifications@github.com wrote:

@Sylius https://github.com/Sylius Cancelled vs. Canceled? Afaik,
Canceled is OK in American English, but Cancelled is preferred in other
countries... opinions?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1208#issuecomment-37766761
.

[ruudkobes]

+1 for "cancelled"

[kayue]

@pjedrzejewski Ready to merge :)

[winzou]

Don't remove this

[winzou]

@kayue it's fine but can you keep the pending state.
I have a plan to do some sort of UI for shippers. This state is important as it says that shipment should not be sent yet (= in preparation).

[kayue]

@winzou Are you planning to do it in core?
Will it be hard to distinguish onhold and pending?

[winzou]

In Core or another bundle.
These 2 states are different:

• onhold = a transaction is pending, we do anything with this shipment
• pending = shipment will be sent, but not now, the shipment itself is pending (because it's being packed, waiting for inventory, etc.). Shipments with this state will be displayed to packers UI
• ready = shipment is to be sent, now. Shipments with this state will be displayed to shippers UI

This is just to separate 2 different business: shippers and packers.

We could rename pending to packing to be more explicit? But pending is more general, for the shippers point of view. It could be being packed, but also just waiting for anything else, shippers don't care.

[kayue]

@winzou I see. We have packing state in our project too. 👍

I agree we should be more general here. How about calling it processing? It indicate "some action is required / happening".

[kayue]

@winzou Are you going to contribute this "packers" logic / UI to Sylius?
If not, I don't think we should have it this state in core. We cannot pre-define all the states for developer anyway.

(In our project we have "picking", "packed" then "shipped"..)

[winzou]

Uhm processing for shipment state would mean that the shipment is processing. Whereas here we have items being packed (or whatever else), which is not (so) shipment related.

Yes I'll contribute this to Sylius, that's the aim. I know we cannot have every states for every project, so let's just have this pending state in the middle. With the next states management (finite machine), all this will be anyway highly configurable and changed easily.

[kayue]

Will revert the changes 👍

[winzou]

Can you just squash commits and we're good ;)

[kayue]

Done 👍

[jjanvier]

@winzou @kayue just for my curiosity, do you update your awesome wiki pages each time you make a change on this ?

[kayue]

I don't. I try to follow it instead of change it.

On Wednesday, March 19, 2014, Julien Janvier notifications@github.com
wrote:

@winzou https://github.com/winzou @kayue https://github.com/kayuejust for my curiosity, do you update your awesome wiki pages each time you
make a change on this ?

Reply to this email directly or view it on GitHubhttps://github.com//pull/1208#issuecomment-38046834
.

[jjanvier]

@kayue :( this could be so helpful

[kayue]

I need to make sure I understand it completely first. Will have a second
look when I have time :)

On Friday, March 21, 2014, Julien Janvier notifications@github.com wrote:

@kayue https://github.com/kayue :( this could be so helpful

Reply to this email directly or view it on GitHubhttps://github.com//pull/1208#issuecomment-38265280
.

[jjanvier]

thank you very much :)