Adjust Cart\ItemResolverInterface to remove dependency on Symfony Request class

[stloyd]

After little discussion in #1233 I have decided to follow those suggestion and remove dependency on Request class in ItemResolverInterface.

@pjedrzejewski @patkar What do you think about this change?

[stloyd]

@Sylius What do you think about this new method on interface? It could be removed, but I think it add some clarification into this resolver...

[jjanvier]

Do we need really need resolveItemIdentifier in the interface ? Agree it's useful for us in the CoreBundle but I don't understand what it brings on the CartBundle..

[QuingKhaos]

Hehe, looks good :) It's more a matter of taste, if resolveItemIdentifier should be in the interface.

[pjedrzejewski]

@patkar It definitely should not be in the interface, because our implementation is just one example of adding item to cart. In my projects, I had resolvers which used plain forms to get the items. (without the id of entity in query) so it's up to the implementation to decide. I think the change Request -> $data should be enough. resolveItemIdentifier should be removed from the interface. It can stay on the ItemResolver in core bundle though.

[QuingKhaos]

👍

[stloyd]

@pjedrzejewski Updated. Failed tests are not related to this.

[pjedrzejewski]

Thanks! Cart component can be updated to reflect this now.