Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Addressing], [Promotions], [Shipping], [Web] Move assets into public folder #1241

Merged
merged 1 commit into from
Mar 20, 2014

Conversation

JRomeoSalazar
Copy link
Contributor

Move assets into public folder and modify templates.

Q A
Fixed tickets #1231
License MIT

@stloyd stloyd added the Bug Fix label Mar 20, 2014
@stloyd stloyd added this to the 1.0.0-BETA1 milestone Mar 20, 2014
@winzou
Copy link
Contributor

winzou commented Mar 20, 2014

👍

@@ -4,7 +4,7 @@
{{ parent() }}

{% javascripts output='assets/compiled/sylius-addressing.js'
'@SyliusAddressingBundle/Resources/assets/js/sylius-addressing.js'
'bundles/syliusaddressing/js/sylius-addressing.js'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm... what's the point of this change? Why you didn't change just folder name? (assets => public)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because if you use the @SyliusAddressing way there is a problem with images
in css files. You get a 404 not found error. It tries to find the images at
/Resources.
El 20/03/2014 14:41, "Joseph Bielawski" notifications@github.com escribió:

In
src/Sylius/Bundle/AddressingBundle/Resources/views/Address/create.html.twig:

@@ -4,7 +4,7 @@
{{ parent() }}

 {% javascripts output='assets/compiled/sylius-addressing.js'
  •    '@SyliusAddressingBundle/Resources/assets/js/sylius-addressing.js'
    
  •    'bundles/syliusaddressing/js/sylius-addressing.js'
    

Hmmm... what's the point of this change? Why you didn't change just folder
name? (assets => public)

Reply to this email directly or view it on GitHubhttps://github.com//pull/1241/files#r10794681
.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, totally forgot that Assetic have 2 year old bugs that are not touched =)

stloyd added a commit that referenced this pull request Mar 20, 2014
[Addressing], [Promotions], [Shipping], [Web] Move assets into public folder
@stloyd stloyd merged commit 31f59ee into Sylius:master Mar 20, 2014
@stloyd
Copy link
Contributor

stloyd commented Mar 20, 2014

Thanks!

@JRomeoSalazar
Copy link
Contributor Author

;) 👍

@JRomeoSalazar JRomeoSalazar deleted the move-assets branch March 20, 2014 16:42
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
[Addressing], [Promotions], [Shipping], [Web] Move assets into public folder
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
[Addressing], [Promotions], [Shipping], [Web] Move assets into public folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants