-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Addressing], [Promotions], [Shipping], [Web] Move assets into public folder #1241
Conversation
👍 |
@@ -4,7 +4,7 @@ | |||
{{ parent() }} | |||
|
|||
{% javascripts output='assets/compiled/sylius-addressing.js' | |||
'@SyliusAddressingBundle/Resources/assets/js/sylius-addressing.js' | |||
'bundles/syliusaddressing/js/sylius-addressing.js' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm... what's the point of this change? Why you didn't change just folder name? (assets
=> public
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because if you use the @SyliusAddressing way there is a problem with images
in css files. You get a 404 not found error. It tries to find the images at
/Resources.
El 20/03/2014 14:41, "Joseph Bielawski" notifications@github.com escribió:
In
src/Sylius/Bundle/AddressingBundle/Resources/views/Address/create.html.twig:@@ -4,7 +4,7 @@
{{ parent() }}{% javascripts output='assets/compiled/sylius-addressing.js'
'@SyliusAddressingBundle/Resources/assets/js/sylius-addressing.js'
'bundles/syliusaddressing/js/sylius-addressing.js'
Hmmm... what's the point of this change? Why you didn't change just folder
name? (assets => public)Reply to this email directly or view it on GitHubhttps://github.com//pull/1241/files#r10794681
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said in #1231 There is a know issue about this
kriswallsmith/assetic#53 (comment)
A good article by Luis Cordova:
http://www.craftitonline.com/2011/06/symfony2-beautify-with-assetic-and-a-template-part-ii/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, totally forgot that Assetic have 2 year old bugs that are not touched =)
[Addressing], [Promotions], [Shipping], [Web] Move assets into public folder
Thanks! |
;) 👍 |
[Addressing], [Promotions], [Shipping], [Web] Move assets into public folder
[Addressing], [Promotions], [Shipping], [Web] Move assets into public folder
Move assets into public folder and modify templates.