Update order payment amount before paid. #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,18 +61,33 @@ public function __construct(PaymentProcessorInterface $paymentProcessor, EntityR | |||
| * Get the order from event and create payment. | |||
| * | |||
| * @param GenericEvent $event | |||
| * @throws \InvalidArgumentException | |||
There was a problem hiding this comment.
Add new line before this one.
|
Can you add specs? It would help to be sure we not broke it with external changes... |
|
@stloyd May I know how to run single spec? I tried many different path but no luck.. Thanks. |
$ php bin/phpspec run spec/SpecFileYouWantToTestSpec.php |
|
@kayue go in the directory of the bundle you are working and launch the specs from here : cd src/Sylius/Bundle/CartBundle
../../../../bin/phpspec run |
| $order = $this->getOrder($event); | ||
| $payment = $order->getPayment(); | ||
|
|
||
| if (!$payment instanceof PaymentInterface) { |
There was a problem hiding this comment.
This check is not needed. Checking if the payment is not null should be enough, because it can be only PaymentInterface or null. (see the Order / OrderInterface)
|
@kayue oh yes :) |
stloyd
added a commit
that referenced
this pull request
Mar 20, 2014
Update order payment amount before paid.
|
@kayue Thanks! Hope you will love phpspec same as we do =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This help make sure payment amount is always match with order total.