Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8.0 #12552

Merged
merged 7 commits into from
Apr 23, 2021
Merged

Add support for PHP 8.0 #12552

merged 7 commits into from
Apr 23, 2021

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Apr 20, 2021

Part of #12298.


TODO:

  • Better userland deprecations handling in phpspec

@pamil pamil requested a review from a team as a code owner April 20, 2021 14:52
@probot-autolabeler probot-autolabeler bot added Admin AdminBundle related issues and PRs. API APIs related issues and PRs. Maintenance CI configurations, READMEs, releases, etc. labels Apr 20, 2021
@@ -190,7 +190,6 @@
"phpunit/phpunit": "^8.5",
"psalm/plugin-mockery": "0.7.0",
"psr/event-dispatcher": "^1.0",
"sspooky13/yaml-standards": "^6.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines -126 to -129
exclude:
-
php: 7.3
mysql: 8.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHP 7.3 is long gone.

@@ -42,3 +42,5 @@ suites:
UserBundle: { namespace: Sylius\Bundle\UserBundle, psr4_prefix: Sylius\Bundle\UserBundle, spec_path: src/Sylius/Bundle/UserBundle, src_path: src/Sylius/Bundle/UserBundle }

Behat: { namespace: Sylius\Behat, psr4_prefix: Sylius\Behat, spec_path: src/Sylius/Behat, src_path: src/Sylius/Behat }

runner.maintainers.errors.level: 14335 # E_ALL & ~E_USER_DEPRECATED ^ E_STRICT
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be contributed back to phpspec soon.

"doctrine/doctrine-migrations-bundle": "^3.0",
"egulias/email-validator": "^3.0",
"fzaninotto/faker": "^1.9",
"fakerphp/faker": "^1.10",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been changed in main Sylius/Sylius dependencies already.

@loevgaard
Copy link
Contributor

❤️ ❤️ ❤️

@pamil pamil merged commit 69044b7 into Sylius:master Apr 23, 2021
@pamil pamil deleted the master-php-8 branch April 23, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin AdminBundle related issues and PRs. API APIs related issues and PRs. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants