[API][Product] Expose default variant on product show and index #12649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
May 19, 2021
GSadee
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
GSadee
force-pushed
the
api-expose-default-variant
branch
from
c3ff2c1
to
1639cb0
Compare
lchrusciel
reviewed
May 19, 2021
| { | ||
| Assert::isInstanceOf($object, ProductInterface::class); | ||
|
|
||
| $context[self::ALREADY_CALLED] = true; |
There was a problem hiding this comment.
Perhaps we should add assert of early return in case this class is already called indeed?
There was a problem hiding this comment.
IMO there is no need, because this check is in supportsNormalization method, but I can add it to be in 100% secured
|
|
||
| public function supportsNormalization($data, $format = null, $context = []): bool | ||
| { | ||
| if (isset($context[self::ALREADY_CALLED])) { |
There was a problem hiding this comment.
I would add one more spec for testing of this logic
lchrusciel
approved these changes
May 19, 2021
|
Thanks, Grzegorz! 🥇 |
AdamKasp
added a commit
that referenced
this pull request
May 20, 2021
…er (GSadee) This PR was merged into the 1.10-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | yes? | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | fixes ##12649 | License | MIT Commits ------- ef97569 [API][Product] Add additional specs for product normalizer
AdamKasp
added a commit
to Sylius/SyliusApiBundle
that referenced
this pull request
May 20, 2021
…er (GSadee) This PR was merged into the 1.10-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | yes? | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | fixes #Sylius/Sylius#12649 | License | MIT Commits ------- ef975695645c3b0176d733da55a857aa77f2bfc5 [API][Product] Add additional specs for product normalizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.