Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] add final to clssess, cs fixes #12743

Merged
merged 1 commit into from
Jun 22, 2021
Merged

[API] add final to clssess, cs fixes #12743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Sylius/Bundle/ApiBundle/ApiPlatform/ApiResourceConfigurationMerger.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
namespace Sylius\Bundle\ApiBundle\ApiPlatform;

/** @experimental */
class ApiResourceConfigurationMerger implements ApiResourceConfigurationMergerInterface
final class ApiResourceConfigurationMerger implements ApiResourceConfigurationMergerInterface
{
public function mergeConfigs(...$configs): array
{
Expand Down
2 changes: 1 addition & 1 deletion src/Sylius/Bundle/ApiBundle/ApiPlatform/ResourceMetadataPropertyValueResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
use ApiPlatform\Core\Metadata\Resource\ResourceMetadata;

/** @experimental */
class ResourceMetadataPropertyValueResolver implements ResourceMetadataPropertyValueResolverInteface
final class ResourceMetadataPropertyValueResolver implements ResourceMetadataPropertyValueResolverInteface
{
/** @var ApiResourceConfigurationMergerInterface */
private $apiResourceConfigurationMerger;
Expand Down
2 changes: 1 addition & 1 deletion src/Sylius/Bundle/ApiBundle/Resources/config/services.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@

<service id="Sylius\Bundle\ApiBundle\ApiPlatform\ApiResourceConfigurationMerger" />

<service id="Sylius\Bundle\ApiBundle\ApiPlatform\ResourceMetadataPropertyValueResolver" >
<service id="Sylius\Bundle\ApiBundle\ApiPlatform\ResourceMetadataPropertyValueResolver">
<argument type="service" id="Sylius\Bundle\ApiBundle\ApiPlatform\ApiResourceConfigurationMerger" />
</service>

Expand Down
4 changes: 2 additions & 2 deletions src/Sylius/Bundle/ApiBundle/spec/ApiPlatform/ResourceMetadataPropertyValueResolverSpec.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ function let(ApiResourceConfigurationMergerInterface $apiResourceConfigurationMe
$this->beConstructedWith($apiResourceConfigurationMerger);
}

function it_returns_merged_configs(ApiResourceConfigurationMerger $apiResourceConfigurationMerger): void
function it_returns_merged_configs(ApiResourceConfigurationMergerInterface $apiResourceConfigurationMerger): void
{
$resourceMetadata = new ResourceMetadata(
null,
Expand Down Expand Up @@ -159,7 +159,7 @@ public function it_overwrites_parent_config(ApiResourceConfigurationMergerInterf
)->shouldReturn('child_short_name');
}

public function it_throws_error_if_parent_data_is_array_and_child_type_is_different(ApiResourceConfigurationMerger $apiResourceConfigurationMerger): void
public function it_throws_error_if_parent_data_is_array_and_child_type_is_different(ApiResourceConfigurationMergerInterface $apiResourceConfigurationMerger): void
{
$resourceMetadata = new ResourceMetadata(
'parent_short_name',
Expand Down