Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable version of DoctrineCacheBundle #1276

Merged
merged 1 commit into from
Mar 26, 2014
Merged

Stable version of DoctrineCacheBundle #1276

merged 1 commit into from
Mar 26, 2014

Conversation

jjanvier
Copy link
Contributor

DoctrineCacheBundle has a stable version now.
LiipCacheBundle is deprecated.

@jjanvier
Copy link
Contributor Author

wait for this... I forgot to update the conf.

@jjanvier jjanvier changed the title Stable version of DoctrineCacheBundle [WIP] Stable version of DoctrineCacheBundle Mar 24, 2014
@jjanvier jjanvier changed the title [WIP] Stable version of DoctrineCacheBundle Stable version of DoctrineCacheBundle Mar 24, 2014
@jjanvier
Copy link
Contributor Author

Should be OK, let's way for Travis

@stloyd stloyd added this to the 1.0.0-BETA1 milestone Mar 24, 2014
@winzou
Copy link
Contributor

winzou commented Mar 25, 2014

You forgot config_test.yml ;)

@jjanvier
Copy link
Contributor Author

@winzou thanks ;)

@jjanvier
Copy link
Contributor Author

@Sylius green on php5.4. Build are still too long for 5.3 and 5.5

@stloyd
Copy link
Contributor

stloyd commented Mar 25, 2014

@pjedrzejewski Looks good, and sounds reasonable to depend on new bundle (yet I know it's another BC break).

@winzou
Copy link
Contributor

winzou commented Mar 26, 2014

@stloyd what does it break? As long as you use the sylius alias, it's OK.

@jjanvier
Copy link
Contributor Author

Even the configuration is the same...

pjedrzejewski pushed a commit that referenced this pull request Mar 26, 2014
Stable version of DoctrineCacheBundle
@pjedrzejewski pjedrzejewski merged commit d16be7b into Sylius:master Mar 26, 2014
@pjedrzejewski
Copy link
Member

Thank you Julien!

@jjanvier jjanvier deleted the fix/doctrine-cache branch March 26, 2014 13:44
pamil pushed a commit to pamil/Sylius that referenced this pull request Mar 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants