Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Webpack - Display logo on login page #12849

Merged
merged 1 commit into from Sep 6, 2021
Merged

Conversation

Jibbarth
Copy link
Contributor

Q A
Branch? 1.9
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets N/A
License MIT

Hello 馃憢,

While following webpack tutorial, I noticed that there is no logo on Admin Login page.
By overriding the template Security/_content.html.twig, we could change logo path to use one provided by webpack instead one build with gulp.

I targetted 1.9 branch, tell me if I should change to master or 1.10.

@Jibbarth Jibbarth requested a review from a team as a code owner July 30, 2021 07:52
@probot-autolabeler probot-autolabeler bot added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Jul 30, 2021
@CoderMaggie CoderMaggie merged commit 76330d6 into Sylius:1.9 Sep 6, 2021
@CoderMaggie
Copy link
Member

Thank you, Jib茅! 馃

@Jibbarth Jibbarth deleted the patch-1 branch September 14, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants