[CatalogPromotion][API] Add validation for creating catalog promotion with actions #13071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Sep 8, 2021
GSadee
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | based on #13037 |
| License | MIT |
GSadee
force-pushed
the
api-catalog-promotion-action-validation
branch
from
340352e
to
b68da67
Compare
arti0090
approved these changes
Sep 8, 2021
Comment on lines
+175
to
+176
| json_encode([ | ||
| 'name' => 'T-Shirts discount', |
There was a problem hiding this comment.
I think we should consider something for our contract tests that will allow us to use json files with request body. Because those tests are getting enormously huge with just this funky 💃 code.
There was a problem hiding this comment.
We can probably use json files without problems, but then these tests will become less readable, so I'm not 100% convinced. We should think about that and probably refactor our contracts tests in a separate PR
Comment on lines
+215
to
+218
| $response = $this->client->getResponse(); | ||
|
|
||
| $this->assertResponse( | ||
| $response, |
There was a problem hiding this comment.
Suggested change
| $response = $this->client->getResponse(); | |
| $this->assertResponse( | |
| $response, | |
| $this->assertResponse( | |
| $this->client->getResponse(), |
There was a problem hiding this comment.
I'll change that in another PR
lchrusciel
approved these changes
Sep 8, 2021
Tomanhez
added a commit
that referenced
this pull request
Sep 8, 2021
…(GSadee) This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | #13071 | License | MIT Commits ------- 2c8cc59 [CatalogPromotion][API] Refactor validation of rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.