[Catalog Promotions] Fixing issues with multiple variants #13080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arti0090
commented
Sep 9, 2021
arti0090
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
arti0090
commented
Sep 9, 2021
Comment on lines
87
to
95
| public function addAppliedPromotion(array $promotion): void | ||
| { | ||
| if ($this->appliedPromotions === null) { | ||
| $this->appliedPromotions = $promotion; | ||
| return; | ||
| } | ||
|
|
||
| $this->appliedPromotions = array_merge_recursive($this->appliedPromotions, $promotion); | ||
| } |
There was a problem hiding this comment.
We should consider some changes for
/** @var array */ protected $appliedPromotions = [];
value.
At this moment it does not safe us from storing null value. This lead to problem with array_merge where one value sometimes is null.
Sugestion: change this to protected array $appliedPromotions = []; make adjust in orm file and create the migration that will make this field not null and put default value of empty array.
arti0090
force-pushed
the
fixing-cp-view
branch
from
f8fbe1c
to
376602d
Compare
arti0090
force-pushed
the
fixing-cp-view
branch
from
376602d
to
7dccf0f
Compare
GSadee
reviewed
Sep 9, 2021
...otion/applying_catalog_promotions/seeing_applied_catalog_promotions_on_variants_list.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Provider/CatalogPromotionVariantsProvider.php
Show resolved
Hide resolved
GSadee
reviewed
Sep 9, 2021
...es/promotion/applying_catalog_promotions/seeing_applied_catalog_promotion_on_variant.feature
Outdated
Show resolved
Hide resolved
...otion/applying_catalog_promotions/seeing_applied_catalog_promotions_on_variants_list.feature
Outdated
Show resolved
Hide resolved
|
|
||
| /** @var CatalogPromotionRuleInterface $catalogPromotionRule */ | ||
| $catalogPromotionRule = $this->catalogPromotionRuleFactory->createNew(); | ||
| $catalogPromotionRule->setType(CatalogPromotionRuleInterface::TYPE_FOR_VARIANTS); | ||
| $catalogPromotionRule->setConfiguration(['variants' => [$variant->getCode()]]); | ||
| $catalogPromotionRule->setConfiguration(['variants' => array_values($variantCodes)]); |
There was a problem hiding this comment.
Suggested change
| $catalogPromotionRule->setConfiguration(['variants' => array_values($variantCodes)]); | |
| $catalogPromotionRule->setConfiguration(['variants' => $variantCodes]); |
should be enough 🤔
There was a problem hiding this comment.
then it creates something like: 'variants' => 0: 'code1' , 1:'code2' that is why I used array_values
src/Sylius/Bundle/CoreBundle/Provider/CatalogPromotionVariantsProvider.php
Outdated
Show resolved
Hide resolved
arti0090
force-pushed
the
fixing-cp-view
branch
from
f52a947
to
ee8b0e6
Compare
arti0090
force-pushed
the
fixing-cp-view
branch
from
ee8b0e6
to
41d7c2f
Compare
GSadee
approved these changes
Sep 10, 2021
|
Thanks, @arti0090! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.