Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize flushes in Catalog Promotions processing #13133

Merged
merged 1 commit into from Sep 22, 2021
Merged

Reorganize flushes in Catalog Promotions processing #13133

merged 1 commit into from Sep 22, 2021

Conversation

Zales0123
Copy link
Member

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

The previous implementation was causing unexpected doctrine event cascades that resulted in multiple applied promotions in some cases 馃拑 Calling flush only once should fix this problem once for ever 馃殌

@Zales0123 Zales0123 added DX Issues and PRs aimed at improving Developer eXperience. Bug Confirmed bugs or bugfixes. labels Sep 22, 2021
@Zales0123 Zales0123 requested a review from a team as a code owner September 22, 2021 10:40
@GSadee GSadee merged commit 48cff6b into Sylius:master Sep 22, 2021
@GSadee
Copy link
Member

GSadee commented Sep 22, 2021

Thanks, Mateusz! 馃帀

@Zales0123 Zales0123 deleted the reorganize-flushes branch September 22, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@arti0090 arti0090 arti0090 approved these changes

@Tomanhez Tomanhez Tomanhez approved these changes

Assignees
No one assigned
Labels
Bug Confirmed bugs or bugfixes. DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Zales0123 @GSadee @arti0090 @Tomanhez