Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core][Checkout] fixed #13201 #13202

Merged
merged 2 commits into from
Nov 7, 2022
Merged

[Core][Checkout] fixed #13201 #13202

merged 2 commits into from
Nov 7, 2022

Conversation

acornforth
Copy link
Contributor

@acornforth acornforth commented Oct 13, 2021

use canonicalized email for customer lookup on CustomerGuestFormTypes

Caused insert duplicate errors on customer table for repeat guest customers

Q A
Branch? 1.11
Bug fix? yes
New feature? no
BC breaks? no?
Deprecations? no
Related tickets fixes #13201
License MIT

@acornforth acornforth requested a review from a team as a code owner October 13, 2021 15:14
@acornforth
Copy link
Contributor Author

Would this be more likely to attract the attention of the core team and be reviewed/merged is if was properly labelled as a Bug Fix ? I am unable to do it.

@stloyd
Copy link
Contributor

stloyd commented Jan 20, 2022

I can confirm this issue, was doing similar adjustment to email to prevent duplication of users with same email.

@Roshyo
Copy link
Contributor

Roshyo commented Jan 20, 2022

Could you come up with some test about this scenario please ?

@Roshyo Roshyo self-requested a review January 20, 2022 15:55
@acornforth
Copy link
Contributor Author

While I can justify submitting this fix i already made during my work hours, my workload is quite heavy at the moment, and any tests i write would have to be done on my own time, and i don't have much at the moment, which means i can't get to it for a while. If anyone else can add the required tests and get this merged i'm sure it will be appreciated. Unfortunately i cannot right now.

@SirDomin SirDomin changed the base branch from 1.9 to 1.10 May 10, 2022 10:34
@SirDomin
Copy link
Contributor

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "issue_13201" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label May 10, 2022
@lchrusciel lchrusciel changed the base branch from 1.10 to 1.9 May 10, 2022 10:37
@lchrusciel lchrusciel changed the base branch from 1.9 to 1.10 May 10, 2022 10:38
@SirDomin
Copy link
Contributor

The problem occurs on PostgreSQL only, all mysql builds seems to be working correctly, /cc @Ferror

@lchrusciel
Copy link
Member

Can be continued after #13786

acornforth and others added 2 commits November 4, 2022 14:39
use canonicalized email for customer lookup on CustomerGuestFormTypes

Caused insert duplicate errors on customer table for repeat guest customers
@TheMilek TheMilek self-assigned this Nov 4, 2022
@probot-autolabeler probot-autolabeler bot added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Nov 4, 2022
@TheMilek TheMilek changed the base branch from 1.10 to 1.11 November 4, 2022 13:51
@GSadee GSadee added the Bug Confirmed bugs or bugfixes. label Nov 7, 2022
@GSadee GSadee merged commit d270ac4 into Sylius:1.11 Nov 7, 2022
@GSadee
Copy link
Member

GSadee commented Nov 7, 2022

Thank you, Andrew! 🎉

@acornforth acornforth deleted the issue_13201 branch November 15, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bugs or bugfixes. Documentation Documentation related issues and PRs - requests, fixes, proposals. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants