-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core][Checkout] fixed #13201 #13202
Conversation
Would this be more likely to attract the attention of the core team and be reviewed/merged is if was properly labelled as a Bug Fix ? I am unable to do it. |
I can confirm this issue, was doing similar adjustment to email to prevent duplication of users with same email. |
Could you come up with some test about this scenario please ? |
While I can justify submitting this fix i already made during my work hours, my workload is quite heavy at the moment, and any tests i write would have to be done on my own time, and i don't have much at the moment, which means i can't get to it for a while. If anyone else can add the required tests and get this merged i'm sure it will be appreciated. Unfortunately i cannot right now. |
The base of this pull-request was changed, you need fetch and reset your local branch Unless you added new commits (to this branch) locally that you did not push yet, Feel free to ask for assistance when you get stuck 👍 |
The problem occurs on PostgreSQL only, all mysql builds seems to be working correctly, /cc @Ferror |
Can be continued after #13786 |
use canonicalized email for customer lookup on CustomerGuestFormTypes Caused insert duplicate errors on customer table for repeat guest customers
Thank you, Andrew! 🎉 |
use canonicalized email for customer lookup on CustomerGuestFormTypes
Caused insert duplicate errors on customer table for repeat guest customers