-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run CI on Symfony 5.2 and 5.3 #13253
Conversation
Currently blocked by: #13263 |
Can we move forward with this PR? Also, perhaps we should bump the node requirement to 14.04. Can you also target branch 1.9? |
@lchrusciel Yes the conflict is gone, so the road to Symfony 5.3 and php 8 is open again. 1.9 doesn't support php 8, right? And it still has the Symfony ^5.2 constraint. So I don't think we can/should target the 1.9 branch. It'll test against 5.3 already and won't use php 8. Would you prefer to test 1.10 and up against 5.2 and 5.3 or is just 5.3 enough (and of course keep 4.4)? I'm fine with bumping the Node version. |
Oh, you are correct, 1.9 is already tested with 5.3. So let's keep it with branch 1.10. And if you can, please change node version. I would stay with testing v4.4, v5.2, and v5.3 |
@lchrusciel This should be good to go now, please review it 😃 |
And merged! Thanks Youri! |
Run CI on both Symfony 5.2 and 5.3.