Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI on Symfony 5.2 and 5.3 #13253

Merged
merged 4 commits into from
Nov 4, 2021
Merged

Run CI on Symfony 5.2 and 5.3 #13253

merged 4 commits into from
Nov 4, 2021

Conversation

4c0n
Copy link
Contributor

@4c0n 4c0n commented Oct 27, 2021

Q A
Branch? 1.10 master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
License MIT

Run CI on both Symfony 5.2 and 5.3.

@4c0n 4c0n requested a review from a team as a code owner October 27, 2021 13:13
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Oct 27, 2021
@4c0n
Copy link
Contributor Author

4c0n commented Oct 27, 2021

Currently blocked by: #13263

@4c0n 4c0n marked this pull request as draft October 27, 2021 13:38
@lchrusciel
Copy link
Member

Can we move forward with this PR? Also, perhaps we should bump the node requirement to 14.04. Can you also target branch 1.9?

@4c0n
Copy link
Contributor Author

4c0n commented Nov 2, 2021

@lchrusciel Yes the conflict is gone, so the road to Symfony 5.3 and php 8 is open again.

1.9 doesn't support php 8, right? And it still has the Symfony ^5.2 constraint. So I don't think we can/should target the 1.9 branch. It'll test against 5.3 already and won't use php 8.

Would you prefer to test 1.10 and up against 5.2 and 5.3 or is just 5.3 enough (and of course keep 4.4)?

I'm fine with bumping the Node version.

@lchrusciel
Copy link
Member

Oh, you are correct, 1.9 is already tested with 5.3. So let's keep it with branch 1.10. And if you can, please change node version.

I would stay with testing v4.4, v5.2, and v5.3

@4c0n 4c0n marked this pull request as ready for review November 4, 2021 08:19
@4c0n
Copy link
Contributor Author

4c0n commented Nov 4, 2021

@lchrusciel This should be good to go now, please review it 😃

@lchrusciel lchrusciel merged commit 0d4af82 into Sylius:1.10 Nov 4, 2021
@lchrusciel
Copy link
Member

And merged! Thanks Youri!

@4c0n 4c0n deleted the test-on-5_2-and-5_3 branch November 4, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants