[Core] Authenticate the user before saving it #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pjedrzejewski can it be merged before components? |
pjedrzejewski
pushed a commit
that referenced
this pull request
Apr 8, 2014
[Core] Authenticate the user before saving it
|
Done, thanks! I'll rebase the components branch. |
|
@winzou "Tests pass? specs yes", I would say "bulls**t", they cannot pass as they not exists for this class =) |
|
@pjedrzejewski IMO this is not correct fix. There is dispatched event for some reason, not just because it's nice, and that event should be handled by FOSUserBundle already, if it's not the bug is somewhere between those two. |
winzou
added a commit
to winzou/Sylius
that referenced
this pull request
Apr 9, 2014
lsmith77
pushed a commit
to lsmith77/Sylius
that referenced
this pull request
May 14, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User was not authenticated, so the listener was not linking User and Order because it was using security context.