[CatalogPromotion][Admin] Fix displaying fixed discount action on catalog show page #13397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Dec 15, 2021
GSadee
commented
| Q | A |
|---|---|
| Branch? | 1.11 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes #13325 |
| License | MIT |
GSadee
added
Admin
AdamKasp
approved these changes
Dec 15, 2021
AdamKasp
approved these changes
Dec 16, 2021
Comment on lines
+10
to
+17
| {% for channelCode, channelConfiguration in action.configuration %} | ||
| <tr> | ||
| <td class="five wide"><strong class="gray text">{{ channelCode }}</strong></td> | ||
| <td {{ sylius_test_html_attribute('action-' ~ channelCode ~ '-amount') }}> | ||
| {{ money.format(channelConfiguration.amount, currencies[channelCode]) }} | ||
| </td> | ||
| </tr> | ||
| {% endfor %} |
There was a problem hiding this comment.
Suggested change
| {% for channelCode, channelConfiguration in action.configuration %} | |
| <tr> | |
| <td class="five wide"><strong class="gray text">{{ channelCode }}</strong></td> | |
| <td {{ sylius_test_html_attribute('action-' ~ channelCode ~ '-amount') }}> | |
| {{ money.format(channelConfiguration.amount, currencies[channelCode]) }} | |
| </td> | |
| </tr> | |
| {% endfor %} | |
| {% for channelCode, channelConfiguration in action.configuration %} | |
| <tr> | |
| <td class="five wide"><strong class="gray text">{{ channelCode }}</strong></td> | |
| <td {{ sylius_test_html_attribute('action-' ~ channelCode ~ '-amount') }}> | |
| {{ money.format(channelConfiguration.amount, currencies[channelCode]) }} | |
| </td> | |
| </tr> | |
| {% endfor %} |
There was a problem hiding this comment.
I did it on purpose to make it display well in HTML 😃
|
Thanks, Grzegorz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.