Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation][CatalogPromotion] Add cookbook about creating a custom action + minor improvements #13398

Merged
merged 4 commits into from
Dec 16, 2021

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Dec 15, 2021

Q A
Branch? 1.11
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets partially fixes ##13325 (comment)
License MIT

This PR contains a minor refactor of parameters with types of actions/scopes passed to validators.

@GSadee GSadee added Documentation Documentation related issues and PRs - requests, fixes, proposals. DX Issues and PRs aimed at improving Developer eXperience. labels Dec 15, 2021
@GSadee GSadee requested a review from a team as a code owner December 15, 2021 10:17
@GSadee GSadee force-pushed the docs-cookbook-catalog-promotion-action branch from f20f759 to e45593d Compare December 16, 2021 09:11
@AdamKasp AdamKasp merged commit 955517f into Sylius:1.11 Dec 16, 2021
@AdamKasp
Copy link
Contributor

Thanks, Grzegorz! 🥇

@GSadee GSadee deleted the docs-cookbook-catalog-promotion-action branch December 16, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals. DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants