Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DX] add correct return type to getAdjustments method #13575

Merged
merged 1 commit into from
Feb 24, 2022
Merged

[DX] add correct return type to getAdjustments method #13575

merged 1 commit into from
Feb 24, 2022

Conversation

PILLOWPET
Copy link

Q A
Branch? 1.10
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@PILLOWPET PILLOWPET requested a review from a team as a code owner February 1, 2022 12:09
@Roshyo Roshyo changed the title fix(order): add correct return type to getAdjustments method [DX] add correct return type to getAdjustments method Feb 8, 2022
@Zales0123 Zales0123 added DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). labels Feb 24, 2022
@Zales0123 Zales0123 merged commit 0c487a1 into Sylius:1.10 Feb 24, 2022
@Zales0123
Copy link
Member

Zales0123 commented Feb 24, 2022 •
edited

Thanks, Hadrien and welcome to the Community! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 approved these changes

@Roshyo Roshyo Roshyo approved these changes

@loic-carbonne loic-carbonne loic-carbonne approved these changes

Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PILLOWPET @Zales0123 @Roshyo @loic-carbonne