Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce templating helpers to allow replacing Twig as templating engine #1388

Merged
merged 2 commits into from
Apr 17, 2014

Conversation

stloyd
Copy link
Contributor

@stloyd stloyd commented Apr 15, 2014

Second step to conquer the world :trollface:

@jjanvier
Copy link
Contributor

👍

Thanks, I didn't know this templating helper thing provided by Symfony.

Just one remark. Shouldn't you define some interfaces for these helpers ? And use them in the contructors of your extensions ?

@jjanvier
Copy link
Contributor

Didn't see the WIP, maybe I talked too fast sorry...

@pjedrzejewski
Copy link
Member

Definitely a 👍, but as @jjanvier said, I think interfaces would be nice here, what do you think @stloyd?

@stloyd
Copy link
Contributor Author

stloyd commented Apr 16, 2014

I'm not sure about interfaces... mainly cause the logic is created by us, and saying we accept interface means that we don't know have no idea about logic anymore.

Symfony i.e. passes typehinted helpers (from which I have borred this idea), or even calls helper via container (due to DI scope problems [mostly when calling render() stuff], that twig as templating "scope" can't reference/call to other templating "scope").

@pjedrzejewski
Copy link
Member

@stloyd I think you are right.

@stloyd
Copy link
Contributor Author

stloyd commented Apr 17, 2014

@pjedrzejewski what do you think about this? (I will add CHANGELOG notes)

@pjedrzejewski
Copy link
Member

@stloyd 👍, please add the changelogs and I'll merge it. Thanks!

@stloyd stloyd changed the title [WIP] Introduce templating helpers to allow replacing Twig as templating engine Introduce templating helpers to allow replacing Twig as templating engine Apr 17, 2014
@stloyd
Copy link
Contributor Author

stloyd commented Apr 17, 2014

@pjedrzejewski Done =)

pjedrzejewski pushed a commit that referenced this pull request Apr 17, 2014
Introduce templating helpers to allow replacing Twig as templating engine
@pjedrzejewski pjedrzejewski merged commit 56c4971 into Sylius:master Apr 17, 2014
@pjedrzejewski
Copy link
Member

Thanks Joseph!

@stloyd stloyd deleted the feature/templating_helpers branch April 17, 2014 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants