-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce templating helpers to allow replacing Twig as templating engine #1388
Introduce templating helpers to allow replacing Twig as templating engine #1388
Conversation
👍 Thanks, I didn't know this templating helper thing provided by Symfony. Just one remark. Shouldn't you define some interfaces for these helpers ? And use them in the contructors of your extensions ? |
Didn't see the WIP, maybe I talked too fast sorry... |
I'm not sure about interfaces... mainly cause the logic is created by us, and saying we accept interface means that we don't know have no idea about logic anymore. Symfony i.e. passes typehinted helpers (from which I have borred this idea), or even calls helper via container (due to DI scope problems [mostly when calling |
@stloyd I think you are right. |
@pjedrzejewski what do you think about this? (I will add |
@stloyd 👍, please add the changelogs and I'll merge it. Thanks! |
@pjedrzejewski Done =) |
Introduce templating helpers to allow replacing Twig as templating engine
Thanks Joseph! |
Second step to conquer the world![:trollface: :trollface:](https://github.githubassets.com/images/icons/emoji/trollface.png)