Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed version specification #14123

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Removed version specification #14123

merged 1 commit into from
Jul 7, 2022

Conversation

vjandrea
Copy link
Contributor

@vjandrea vjandrea commented Jul 4, 2022

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets none
License MIT

No need to specify the version here IMHO, since composer create-project will always use the latest stable.

@vjandrea vjandrea requested a review from a team as a code owner July 4, 2022 10:19
@probot-autolabeler probot-autolabeler bot added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Jul 4, 2022
@lchrusciel
Copy link
Member

Hey Andrea!

thanks for the proposal. You are right, thanks for the fix :) Can you, however, open a PR to 1.11 branch and resolve conflict?

No need to specify the version here IMHO, since `composer create-project` will always use the latest stable.
@Zales0123 Zales0123 changed the base branch from master to 1.11 July 7, 2022 13:51
@Zales0123
Copy link
Member

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "patch-1" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@Zales0123 Zales0123 merged commit 40f2a9f into Sylius:1.11 Jul 7, 2022
@Zales0123
Copy link
Member

Thanks, Andrea! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants