New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maintenance] Add support for doctrine/dbal:^3.0 #14145
Conversation
It seems support for dbal3 works (and dbal2, too!). Two areas required changes:
Migrations Deprecations |
src/Sylius/Bundle/CoreBundle/Doctrine/Migrations/AbstractMySqlMigration.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Doctrine/Migrations/AbstractMySqlMigration.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Installer/Provider/DatabaseSetupCommandsProvider.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Doctrine/Migrations/AbstractMySqlMigration.php
Outdated
Show resolved
Hide resolved
@@ -57,7 +53,7 @@ public function down(Schema $schema): void | |||
|
|||
private function getExistingIndexesNames(string $tableName): array | |||
{ | |||
$indexes = $this->connection->getSchemaManager()->listTableIndexes($tableName); | |||
$indexes = $this->connection->createSchemaManager()->listTableIndexes($tableName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing fallback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be probably something like this 🖖
Thanks, Jakub! 🥇 |
…dbal:3.*` (Rafikooo) This PR was merged into the 1.12 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.12 and 1.13 <!-- see the comment below --> | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file --> | | License | MIT | It should probably be removed along with #14145 Commits ------- [ApiBundle][Maintenance] Remove conflict with doctrine/dbal:3.*
This PR adds support for
doctrine/dbal:^3.0
. Some tests are failing and I have to fix them but it's ready to review the approach.Removing
NULL COMMENT \'(DC2Type:json_array)\'
was necessary because setting up a fresh database using migrations was failing.