[Bundle][Attribute]It will also listen on the product attribute objec… #14202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrPogos
commented
Jul 29, 2022
MrPogos
commented
| Q | A |
|---|---|
| Branch? | 1.11 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes #14185 |
| License | MIT |
…t for protection against deletion when it is used by the product object
lchrusciel
reviewed
Aug 3, 2022
There was a problem hiding this comment.
Hey @MrPogos,
thanks a lot for your proposal! We appreciate it :) However, without reproducing scenario, I won't merge it. In addition, changes in previously generated are by default no-go for us. Can you alter your PR with:
- write behat scenario, that would cover your case
- revering changes to already generated migration
- adding new migration that will remove
CASCADEon delete
src/Sylius/Bundle/CoreBundle/Migrations/Version20161202011555.php
Outdated
Show resolved
Hide resolved
added 2 commits
August 3, 2022 15:05
…nd added a migration that disables cascading removal.
lchrusciel
approved these changes
Aug 8, 2022
|
|
||
| @ui | ||
| Scenario: Try deleting a attribute from the registry when product use him | ||
| And this product has a text attribute "Gun caliber" with value "11 mm" |
There was a problem hiding this comment.
Suggested change
| And this product has a text attribute "Gun caliber" with value "11 mm" | |
| Given this product has a text attribute "Gun caliber" with value "11 mm" |
lchrusciel
reviewed
Aug 9, 2022
| @managing_product_attributes | ||
| Feature:Removing a attribute | ||
| As an administrator | ||
| I want to be able to remove a attribute that is not assigned to any of the products |
There was a problem hiding this comment.
Suggested change
| I want to be able to remove a attribute that is not assigned to any of the products | |
| I want to be able to remove an attribute that is not assigned to any of the products |
| @@ -0,0 +1,21 @@ | |||
| @managing_product_attributes | |||
| Feature:Removing a attribute | |||
| As an administrator | |||
There was a problem hiding this comment.
Suggested change
| As an administrator | |
| In order to keep my collection of product attributes not cluttered | |
| As an administrator |
|
Thanks @MrPogos and Patryk! 🎉 |
Zales0123
added a commit
that referenced
this pull request
Aug 11, 2022
…lchrusciel) This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.11 | | Bug fix? | yes | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Related tickets | review from #14202 | | License | MIT | <!-- - Bug fixes must be submitted against the 1.11 branch - Features and deprecations must be submitted against the 1.12 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 1a5529a [Minor][Behat] Attributes deletion scenario improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.