New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some composer.json
files
#1422
Conversation
@pjedrzejewski @jjanvier @umpirsky Anything blocking this one? |
@@ -35,7 +35,7 @@ | |||
"psr-4": { "Sylius\\Component\\Pricing\\": "" } | |||
}, | |||
"autoload-dev": { | |||
"psr-4": { "spec\\Sylius\\Component\\Pricing\\": "spec/" } | |||
"psr-4": { "Sylius\\Component\\Pricing\\spec\\": "spec/" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure about this? The namespace starts with spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both ways are correct, but this one makes it consistent with other composer.json
files.
- add missing dependencies - remove not required ones - adjust some dependencies to be same like in other parts of Sylius - add missing dev stability parameter when required
@pjedrzejewski We really need to have Travis setups for all read-only tree splits, without this we can't be sure that bundles/components have all required dependencies (i.e. Core component have 2 missing ones)... Additionally I have added |
@pjedrzejewski This should be merged before relase of |
Fix some `composer.json` files
Looks good to me, I renabled travis for all repos, let's see what happens. :) |
Fix some `composer.json` files
Fix some `composer.json` files
Fix some `composer.json` files
Fix some `composer.json` files
Fix some `composer.json` files
Fix some `composer.json` files
Fix some `composer.json` files
Fix some `composer.json` files
Without this trying to test Pricing Component is broken.