[Symfony 6] Remove setting services for test as public #14407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Zales0123
commented
Oct 4, 2022
Zales0123
commented
| Q | A |
|---|---|
| Branch? | symfony-6 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | mentioned in this comment |
| License | MIT |
Zales0123
added
DX
loic425
approved these changes
Oct 4, 2022
Zales0123
force-pushed
the
remove-unneeded-public-services-in-test
branch
from
74799ae
to
8e88eb1
Compare
GSadee
approved these changes
Oct 4, 2022
Zales0123
force-pushed
the
remove-unneeded-public-services-in-test
branch
from
8e88eb1
to
48df084
Compare
NoResponseMate
approved these changes
Oct 5, 2022
Zales0123
force-pushed
the
remove-unneeded-public-services-in-test
branch
from
48df084
to
8216e50
Compare
GSadee
force-pushed
the
remove-unneeded-public-services-in-test
branch
from
8216e50
to
a49d879
Compare
coldic3
approved these changes
Oct 6, 2022
|
Thanks, Mateusz! 🎉 |
Zales0123
added a commit
that referenced
this pull request
Oct 7, 2022
…, GSadee, coldic3) This PR was merged into the 1.12 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | master | | Bug fix? | no | | New feature? | yes | | BC breaks? | hope no | | Deprecations? | no | | Related tickets | fixes #13274 | | License | MIT | <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 4f5040f [Maintenance] Update routings' `controller` node syntax 4292d52 Skip tests that cannot be fixed now 1b5e74d Extract session management in tests a8f8b71 Revert SyliusLabs/PolyfilSymfonySecurity fork branch 0de67b7 [Maintenance] Support both UserPasswordEncoder & UserPasswordHasher c4e08e4 [Maintenance] PasswordUpdater supports both Symfony 5.4 & Symfony 6 e585559 [Maintenance] psalm.xml updated with deprecated class and interface 5bd0839 Use Symfony Mailer by default 8ffa91d [Test] Refactor EmailChecker to work with Symfony Mailer 04963ce [Maintenance] Transform email html content to text 3d2fafd [Maintenance] Update email assertion in Unit tests ab61828 [Maintenance] Remove Swiftmailer-based unit tests 23eda82 [Maintenance] Updated mailer config 3f47138 [Maintenance] Move EmailChecker from Core into Behat 1efe040 [Behat] Fix SecurityService to work with new session management flow e8c1f5f [Behat] Add session hook context bd261c4 [Maintenance][Behat] Temporarily allow failing cli tests 254682f [Maintenance] Bring back swiftmailer-based tests in packages 4253917 [Maintenance] Fix test apps configuration for swiftmailer env 2e47204 [Behat] Add session hook context 26a7da8 Temporarily run only features/account/ Behat scenarios in Symfony 6 c814085 Fix Behat scenarios for User account 129974b Composer.json fixes 05ee163 Remove some deprecations to fix most of Behat scenarios 868c503 Do not reset token storage between tests 368a280 Make IriConverter stateless 011ad0b Return the whole application build 7fd70d0 Return temporarily removed workflows fadbe0d Remove duplicated code in CachedRouteNameResolver 50e2967 Remove duplicated code in Symfony6PrivateServicesPass 3a5b69d [ProductAttribute] The way of processing query parameters changed 11b9fc2 [GithubActions] Redundand Run JS Behat command removed 85f180f [Forms] Legacy error messages disabled 74f599b [Promotions][Behat] Form validation message changed according to the new messaging system 1f43b43 [Behat] Unused step implementation removed 5a53028 [CatalogPromotions][API][Behat] Step with a different behavior in SF-5.4 and SF-6 changed d7448f2 [Behat][API][Admin] Proper IRIs in the admin context bc7abda Fix encore build for AdminBundle and CoreBundle 1bcbb48 Fix packages versions 7ee060c Remove unneeded ApiPlatform version check in static checks da97c99 Fix deprecated controller syntax to fix the build d321bee [Github Actions] Make timeout for non-JS build longer e95b96f bug #14414 [Github Actions] Make timeout for non-JS build longer (Zales0123) a49d879 [Symfony 6] Remove setting services for test as public 90de5a2 bug #14407 [Symfony 6] Remove setting services for test as public (Zales0123)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.