Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated twig/intl-extra to allow v3 #14641

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Updated twig/intl-extra to allow v3 #14641

merged 2 commits into from
Dec 14, 2022

Conversation

UlrichHP
Copy link
Contributor

Q A
Branch? 1.12
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets mentioned in #14628
License MIT

@UlrichHP UlrichHP requested a review from a team as a code owner December 14, 2022 10:49
@jakubtobiasz
Copy link
Contributor

Hi @UlrichHP!
Thanks for your contribution 🎉 . Can you fix the build? You need to adjust the package's version also in subpackages.
CleanShot 2022-12-14 at 13 44 07@2x

@probot-autolabeler probot-autolabeler bot added Admin AdminBundle related issues and PRs. Shop ShopBundle related issues and PRs. labels Dec 14, 2022
@UlrichHP
Copy link
Contributor Author

Hi @jakubtobiasz,

Sorry about that, i fixed it.

jakubtobiasz
jakubtobiasz approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@jakubtobiasz jakubtobiasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok for me 👍🏼.

@GSadee GSadee merged commit 4347cea into Sylius:1.12 Dec 14, 2022
@GSadee
Copy link
Member

GSadee commented Dec 14, 2022

Thank you, Ulrich! 🥇

@UlrichHP UlrichHP deleted the twig-intl-extra-update branch December 14, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@NoResponseMate NoResponseMate NoResponseMate approved these changes

@coldic3 coldic3 coldic3 approved these changes

@jakubtobiasz jakubtobiasz jakubtobiasz approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs. Shop ShopBundle related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@UlrichHP @jakubtobiasz @GSadee @NoResponseMate @coldic3