Add ability to remove attributes from product #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <div class="col-md-11"> | ||
| {{ form_widget(member[form.type.vars.value], {'attr': {'class': 'select2 float-right input-large'}}) }} | ||
| </div> | ||
| <div class="col-md-1"> | ||
| <a href="#" class="btn btn-danger collection-remove-btn float-left"><i class="glyphicon glyphicon-trash icon-white"></i></a> | ||
| <a href="#" class="btn btn-danger collection-remove-btn float-left" data-collection-button="delete" data-collection="sylius-zone-members" data-collection-item="{{ form.type.vars.value }}"><i class="glyphicon glyphicon-trash icon-white"></i></a> |
There was a problem hiding this comment.
IIRC this CSS class: collection-remove-btn can be removed.
|
i would love to see this integrated |
|
Yes, i hope this features is integrated soon :) |
|
@lbaey Please "squash" you commits a bit (at least to remove duplicates & "merge" commits), you should not "merge" master branches into your fork, you should use "rebase" functionality. |
|
@lbaey I have fixed you branch, it should work now as expected =) |
|
@stloyd thank you so much |
|
@pjedrzejewski 👍 for this one ;) |
pjedrzejewski
pushed a commit
that referenced
this pull request
May 15, 2014
Add ability to remove attributes from product
|
Thank you @lbaey! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been asked to add attribute value removal functionality to the Backend product form.
This is how I did it, what do you think ?