Throw exception if sequence generator not found #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
|
||
| continue; | ||
| } | ||
| $generator = $this->registry->get($entity); |
There was a problem hiding this comment.
I would actually catch the generic exception and throw a sequence-specific one, easier to debug and control.
There was a problem hiding this comment.
I know. I was lazy 👅
|
That's efficiency! |
| @@ -29,7 +29,7 @@ public function getId(); | |||
| public function getName(); | |||
|
|
|||
| /** | |||
| * @param string $name | |||
| * @param string $name | |||
There was a problem hiding this comment.
I see you run CS fixer... and again it fails with such changes =)
Correct one is new line between @param & @return.
| { | ||
| public function __construct($entity, NonExistingServiceException $e) | ||
| { | ||
| parent::__construct(sprintf('Generator for entity "%s" does not exist.', get_class($entity)), 0, $e); |
There was a problem hiding this comment.
We can be even clearer in the exception message:
... You must add it in your sylius.yml configuration file. For example: sylius_sequence.generators.%s: sylius.sequence.sequential_number_generator
And replace the 0 by $e->getCode() ;)
pjedrzejewski
pushed a commit
that referenced
this pull request
May 15, 2014
Throw exception if sequence generator not found
|
That was buggin me as well, thanks guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.