Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvement of SingleChannelContext #15061

Merged
merged 1 commit into from Jun 22, 2023
Merged

Performance improvement of SingleChannelContext #15061

merged 1 commit into from Jun 22, 2023

Conversation

coldic3
Copy link
Contributor

@coldic3 coldic3 commented May 22, 2023

Q A
Branch? 1.13
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

There is no need to fetch all channels only to check there is only one channel.

@coldic3 coldic3 requested a review from a team as a code owner May 22, 2023 13:45
@coldic3 coldic3 force-pushed the feature/single-channel-context-performance-improvement branch from 70694db to b4ca308 Compare May 22, 2023 13:50
jakubtobiasz
jakubtobiasz previously approved these changes May 25, 2023
View reviewed changes
@coldic3 coldic3 force-pushed the feature/single-channel-context-performance-improvement branch from b4ca308 to 684d6bd Compare June 2, 2023 10:48
@coldic3 coldic3 force-pushed the feature/single-channel-context-performance-improvement branch from 684d6bd to c08715c Compare June 2, 2023 10:49
@jakubtobiasz jakubtobiasz force-pushed the feature/single-channel-context-performance-improvement branch from c08715c to e6e6038 Compare June 22, 2023 09:41
@jakubtobiasz jakubtobiasz added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Jun 22, 2023
@jakubtobiasz jakubtobiasz merged commit f5ee41f into Sylius:1.13 Jun 22, 2023
23 checks passed
@jakubtobiasz
Copy link
Member

Thank you, @coldic3!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel left review comments

@NoResponseMate NoResponseMate NoResponseMate left review comments

@jakubtobiasz jakubtobiasz jakubtobiasz approved these changes

Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@coldic3 @jakubtobiasz @lchrusciel @NoResponseMate