New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Product] Composite variant resolver #15099
Merged
jakubtobiasz
merged 8 commits into
Sylius:1.13
from
NoResponseMate:SYL-2821/composite-variant-resolver
Jun 22, 2023
Merged
[Product] Composite variant resolver #15099
jakubtobiasz
merged 8 commits into
Sylius:1.13
from
NoResponseMate:SYL-2821/composite-variant-resolver
Jun 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NoResponseMate
commented
Jun 14, 2023
Q | A |
---|---|
Branch? | 1.13 |
Bug fix? | no |
New feature? | yes? |
BC breaks? | no |
Deprecations? | no |
Related tickets | fixes #10817 |
License | MIT |
probot-autolabeler
bot
added
API
APIs related issues and PRs.
Maintenance
CI configurations, READMEs, releases, etc.
labels
Jun 14, 2023
NoResponseMate
added
Enhancement
Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
and removed
API
APIs related issues and PRs.
labels
Jun 14, 2023
coldic3
approved these changes
Jun 14, 2023
NoResponseMate
force-pushed
the
SYL-2821/composite-variant-resolver
branch
from
June 16, 2023 08:54
62aeb5c
to
f03b8a1
Compare
NoResponseMate
force-pushed
the
SYL-2821/composite-variant-resolver
branch
from
June 16, 2023 08:55
f03b8a1
to
5a327fc
Compare
NoResponseMate
force-pushed
the
SYL-2821/composite-variant-resolver
branch
from
June 16, 2023 09:06
5a327fc
to
a7fe8c3
Compare
jakubtobiasz
requested changes
Jun 19, 2023
src/Sylius/Bundle/ProductBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
...dle/ProductBundle/DependencyInjection/Compiler/DefaultProductVariantResolverCompilerPass.php
Outdated
Show resolved
Hide resolved
NoResponseMate
force-pushed
the
SYL-2821/composite-variant-resolver
branch
from
June 20, 2023 09:57
21bc2de
to
577aaab
Compare
jakubtobiasz
approved these changes
Jun 21, 2023
TheMilek
approved these changes
Jun 22, 2023
Thank you, @NoResponseMate! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API
APIs related issues and PRs.
Enhancement
Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Maintenance
CI configurations, READMEs, releases, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.