Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random CS rules, fix some broken phpdocs, fix broken specs #1512

Merged
merged 2 commits into from
May 18, 2014

Conversation

stloyd
Copy link
Contributor

@stloyd stloyd commented May 15, 2014

No description provided.

@@ -25,7 +26,7 @@
class OrderPaymentCallback
{
/**
* @var EntityRepository
* @var RepositoryInterface
*/
protected $orderRepository;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can actually delete completely this attribute, I forgot it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stloyd stloyd changed the title Fix random CS rules, fix some broken phpdocs Fix random CS rules, fix some broken phpdocs, fix broken specs May 16, 2014
@stloyd
Copy link
Contributor Author

stloyd commented May 16, 2014

@pjedrzejewski ping =)

pjedrzejewski pushed a commit that referenced this pull request May 18, 2014
Fix random CS rules, fix some broken phpdocs, fix broken specs
@pjedrzejewski pjedrzejewski merged commit 7b3870c into Sylius:master May 18, 2014
@pjedrzejewski
Copy link
Member

Thank you Joseph!

@stloyd stloyd deleted the bugfix/cs branch May 19, 2014 06:51
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
Fix random CS rules, fix some broken phpdocs, fix broken specs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants